(fix) Make quick search work in Safari#5383
Open
aulterego wants to merge 1 commit intoHDInnovations:developmentfrom
Open
(fix) Make quick search work in Safari#5383aulterego wants to merge 1 commit intoHDInnovations:developmentfrom
aulterego wants to merge 1 commit intoHDInnovations:developmentfrom
Conversation
PR Summary
|
aulterego
changed the title
aulterego
changed the title
Roardom
reviewed
Apr 9, 2026
Comment on lines
+98
to
+102
| navigateToFirstResult() { | ||
| if (Array.isArray(this.searchResults) && this.searchResults.length > 0) { | ||
| window.location.href = this.searchResults[0].url; | ||
| } | ||
| }, |
Collaborator
There was a problem hiding this comment.
Can you move this to a separate commit and PR? It doesn't seem related to the rest of the code (although a useful addition nonetheless).
Safari does not focus <a> elements on click (macOS convention) and does not reliably bubble :active to ancestor elements. This caused the CSS :focus-within/:active visibility rule to hide the dropdown before the click event could complete navigation. - Add x-on:mousedown.prevent on result links to retain input focus - Add null-safety to arrow key focus methods
aulterego
force-pushed
the
fix/safari-quick-search
branch
from
a6662fe to
08cb27d
Compare
Collaborator
|
Thanks! @HDVinnie do you mind comparing a before and after on your mac when you have a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The quick search bar on the home page doesn't work on Safari (macOS). Neither pressing return nor clicking on a completion result triggers any action. This is because Safari does not focus elements on click (macOS convention) and does not reliably bubble :active to ancestor elements. This caused the CSS :focus-within/:active visibility rule to hide the dropdown before the click event could complete navigation.
The fix is to:
Also while I'm here we can also:
I've run the project locally and have confirmed the fix works in Safari and does not cause a regression in Firefox.