further simplifications

Author: Guite

bundles/org.zikula.modulestudio.generator/src/org/zikula/modulestudio/generator/cartridges/symfony/controller/menu/ItemActions.xtend

@@ -180,17 +180,15 @@ class ItemActions {
     '''
 
     def private itemActionsForEditAction(Entity it) '''
-        «IF !readOnly»«/*create is allowed, but editing not*/»
-            $menu->addChild('Edit', [
-                'route' => $routePrefix . 'edit',
-                'routeParameters' => $entity->createUrlArgs(«IF hasSluggableFields && slugUnique»true«ENDIF»),
-            ])
-                ->setLinkAttribute('title', 'Edit this «name.formatForDisplay»')
-                «application.addLinkClass('secondary')»
-                «application.addIcon('edit')»
-                ->setExtra('translation_domain', '«name.formatForCode»')
-            ;
-        «ENDIF»
+        $menu->addChild('Edit', [
+            'route' => $routePrefix . 'edit',
+            'routeParameters' => $entity->createUrlArgs(«IF hasSluggableFields && slugUnique»true«ENDIF»),
+        ])
+            ->setLinkAttribute('title', 'Edit this «name.formatForDisplay»')
+            «application.addLinkClass('secondary')»
+            «application.addIcon('edit')»
+            ->setExtra('translation_domain', '«name.formatForCode»')
+        ;
         $menu->addChild('Reuse', [
             'route' => $routePrefix . 'edit',
             'routeParameters' => ['astemplate' => $entity->getKey()],

bundles/org.zikula.modulestudio.generator/src/org/zikula/modulestudio/generator/cartridges/symfony/models/Entities.xtend

@@ -3,7 +3,6 @@ package org.zikula.modulestudio.generator.cartridges.symfony.models
 import de.guite.modulestudio.metamodel.Application
 import de.guite.modulestudio.metamodel.ArrayField
 import de.guite.modulestudio.metamodel.Entity
-import de.guite.modulestudio.metamodel.EntityChangeTrackingPolicy
 import de.guite.modulestudio.metamodel.EntityTreeType
 import org.zikula.modulestudio.generator.application.IMostFileSystemAccess
 import org.zikula.modulestudio.generator.application.ImportList
@@ -262,17 +261,14 @@ class Entities {
          * This is the concrete entity class for «name.formatForDisplay» entities.
          */
         «extMan.classAnnotations»
-        #[ORM\Entity(repositoryClass: «name.formatForCodeCapital»Repository::class«IF readOnly», readOnly: true«ENDIF»)]
+        #[ORM\Entity(repositoryClass: «name.formatForCodeCapital»Repository::class)]
         «entityImplClassAdditionalAttributes(app)»
         «new ValidationConstraints().classAnnotations(it)»
     '''
 
     def private entityImplClassAdditionalAttributes(Entity it, Application app) '''
         #[ORM\Table(name: '«fullEntityTableName»')]
         «workflowIndex('Index')»
-        «IF changeTrackingPolicy != EntityChangeTrackingPolicy::DEFERRED_IMPLICIT»
-            #[ORM\ChangeTrackingPolicy('«changeTrackingPolicy.literal»')]
-        «ENDIF»
     '''
 
     def private workflowIndex(Entity it, String indexType) '''

bundles/org.zikula.modulestudio.generator/src/org/zikula/modulestudio/generator/cartridges/symfony/view/pages/view/ViewHierarchy.xtend

@@ -72,7 +72,7 @@ class ViewHierarchy {
             </div>
         </div>
         <div class="clearfix">
-            <div id="{{ idPrefix }}" class="tree-container" data-root-id="{{ rootId|e('html_attr') }}" data-object-type="«name.formatForCode»" data-urlargnames="«IF hasSluggableFields && slugUnique»slug«ELSE»«getPrimaryKey.name.formatForCode»«IF hasSluggableFields»,slug«ENDIF»«ENDIF»" data-has-detail="«hasDetailAction.displayBool»" data-has-edit="«(hasEditAction && !readOnly).displayBool»">
+            <div id="{{ idPrefix }}" class="tree-container" data-root-id="{{ rootId|e('html_attr') }}" data-object-type="«name.formatForCode»" data-urlargnames="«IF hasSluggableFields && slugUnique»slug«ELSE»«getPrimaryKey.name.formatForCode»«IF hasSluggableFields»,slug«ENDIF»«ENDIF»" data-has-detail="«hasDetailAction.displayBool»" data-has-edit="«hasEditAction.displayBool»">
                 {% if hasNodes %}
                     {% set treeData = «appName.formatForDB»_treeData(objectType='«name.formatForCode»', tree=items, routeArea=routeArea, rootId=rootId) %}
                     <ul id="itemTree{{ rootId|e('html_attr') }}">