Skip to content

Commit 507d554

Browse files
committed
app prefix by convention over configuration
1 parent 1c5e6d8 commit 507d554

File tree

2 files changed

+9
-7
lines changed
  • bundles/org.zikula.modulestudio.generator/src/org/zikula/modulestudio/generator/cartridges/symfony

2 files changed

+9
-7
lines changed

bundles/org.zikula.modulestudio.generator/src/org/zikula/modulestudio/generator/cartridges/symfony/controller/javascript/GeoFunctions.xtend

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,13 @@ package org.zikula.modulestudio.generator.cartridges.symfony.controller.javascri
33
import de.guite.modulestudio.metamodel.Application
44
import org.zikula.modulestudio.generator.application.IMostFileSystemAccess
55
import org.zikula.modulestudio.generator.extensions.ControllerExtensions
6-
import org.zikula.modulestudio.generator.extensions.FormattingExtensions
76
import org.zikula.modulestudio.generator.extensions.ModelBehaviourExtensions
87
import org.zikula.modulestudio.generator.extensions.NamingExtensions
98
import org.zikula.modulestudio.generator.extensions.Utils
109

1110
class GeoFunctions {
1211

1312
extension ControllerExtensions = new ControllerExtensions
14-
extension FormattingExtensions = new FormattingExtensions
1513
extension ModelBehaviourExtensions = new ModelBehaviourExtensions
1614
extension NamingExtensions = new NamingExtensions
1715
extension Utils = new Utils
@@ -174,7 +172,6 @@ class GeoFunctions {
174172

175173
var map;
176174
var objectType;
177-
var fieldPrefix;
178175
var entityMarkers;
179176
var labelMarkers;
180177

@@ -219,7 +216,7 @@ class GeoFunctions {
219216

220217
for (var i = 0; i < markerData.length; i++) {
221218
var marker = markerData[i];
222-
var markerCaption = (marker.image ? '<img src="' + marker.image + '" alt="Logo" style="max-width: 100px !important" /><br />' : '') + marker.title;
219+
var markerCaption = (marker.image ? '<img src="' + marker.image + '" alt="Image" style="max-width: 100px !important" /><br />' : '') + marker.title;
223220
if ('undefined' !== typeof marker.detailUrl && marker.detailUrl) {
224221
markerCaption += '<br /><a href="' + marker.detailUrl + '" target="_blank"><i class="fas fa-arrow-circle-right"></i> Details</a>';
225222
}
@@ -267,7 +264,6 @@ class GeoFunctions {
267264
}
268265

269266
objectType = infoElem.data('object-type');
270-
fieldPrefix = '#«appName.toLowerCase»_' + objectType + 'quicknav_';
271267

272268
parameters = {
273269
tileLayerUrl: infoElem.data('tile-layer-url'),
@@ -276,11 +272,13 @@ class GeoFunctions {
276272

277273
if ('index' == infoElem.data('context')) {
278274
«vendorAndName»InitGeographicalView(parameters);
279-
275+
«/* TODO
280276
jQuery('.«appName.formatForDB»-quicknav').removeClass('form-inline');
281277
jQuery('.«appName.formatForDB»-quicknav input, .«appName.formatForDB»-quicknav select')
282278
.css('width', '100%')
283279
;
280+
*/»
281+
*/
284282
}
285283
});
286284
'''

bundles/org.zikula.modulestudio.generator/src/org/zikula/modulestudio/generator/cartridges/symfony/view/pages/view/ViewMap.xtend

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class ViewMap {
4242
</div>
4343
«(new IndexPagesHelper).pagerCall(it
4444
{% for «name.formatForCode» in items|filter(i => i.latitude|default != 0 and i.longitude|default != 0) %}
45-
<div class="map-marker-definition" data-latitude="{{ «name.formatForCode».latitude|e('html_attr') }}" data-longitude="{{ «name.formatForCode».longitude|e('html_attr') }}" data-title="{{ «name.formatForCode»|«appName.formatForDB»_formattedTitle|e('html_attr') }}" data-image="«IF null !== getMapImageField»{% if «name.formatForCode».«getMapImageField.name.formatForCode» is not empty and «name.formatForCode».«getMapImageField.name.formatForCode»Meta|default %}{{ «name.formatForCode».«getMapImageField.name.formatForCode»Url|e('html_attr') }}{% endif %}«ENDIF»" data-detail-url="«IF hasDetailAction»{{ path('«appName.formatForDB»_«name.formatForCode»_detail'«routeParams(name.formatForCode, true)»)|e('html_attr') }}«ENDIF»"></div>
45+
<div class="map-marker-definition" data-latitude="{{ «name.formatForCode».latitude|e('html_attr') }}" data-longitude="{{ «name.formatForCode».longitude|e('html_attr') }}" data-title="{{ «name.formatForCode»|«appName.formatForDB»_formattedTitle|e('html_attr') }}" data-image="«itemImageUrl»" data-detail-url="«IF hasDetailAction»{{ path('«appName.formatForDB»_«name.formatForCode»_detail'«routeParams(name.formatForCode, true)»)|e('html_attr') }}«ENDIF»"></div>
4646
{% endfor %}
4747
</div>
4848
{% endblock %}
@@ -53,6 +53,10 @@ class ViewMap {
5353
{% endblock %}
5454
'''
5555
56+
def private getItemImageUrl(Entity it) '''
57+
«IF null !== getMapImageField»{% if «name.formatForCode».«getMapImageField.name.formatForCode» is not empty and «name.formatForCode».«getMapImageField.name.formatForCode»Meta|default %}{{ «name.formatForCode».«getMapImageField.name.formatForCode»Url|e('html_attr') }}{% endif %ENDIF»
58+
'''
59+
5660
def private getMapImageField(Entity it) {
5761
if (getUploadFieldsEntity.filter[isOnlyImageField].empty) {
5862
return null

0 commit comments

Comments
 (0)