Check if the block was actually placed - #2522
Closed
thelema1337 wants to merge 1 commit into
Closed
thelema1337 wants to merge 1 commit into
thelema1337 wants to merge 1 commit into
Conversation
SamB440
reviewed
Mar 5, 2026
SamB440
left a comment
SamB440
left a comment
Contributor
There was a problem hiding this comment.
Not entirely sure what this does (how can you place fire?) but I think we should make some method both of these can call to check exemption for scaffolding and fire.
Author
|
@SamB440 At least the BlockPlace class returns StateTypes.FIRE if itemStack.getPlacedType() is null. I have no idea why it returns fire. But if you set something else (like AIR), there will be false positives when using a bucket of water. So, as they say, if it works, don't touch it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a lot of false positives where you could just click on blocks without placing the block at all.