Skip to content

Fix excluded checks can still be enabled - #2386

Merged
ManInMyVan merged 1 commit into
GrimAnticheat:2.0from
Rothes:check-exclude-fix
Jul 18, 2026
Merged

Fix excluded checks can still be enabled#2386
ManInMyVan merged 1 commit into
GrimAnticheat:2.0from
Rothes:check-exclude-fix

Conversation

@Rothes

@Rothes Rothes commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

This makes it possible:

    checks:
      - "Elytra"
      - '!ElytraA'

@ManInMyVan

Copy link
Copy Markdown
Contributor

we could also just remove the enabled thing since we have per-check exempt permissions, or we could put it in config.yml as <check>.enabled

@Rothes

Rothes commented Dec 11, 2025

Copy link
Copy Markdown
Contributor Author

we could also just remove the enabled thing since we have per-check exempt permissions, or we could put it in config.yml as <check>.enabled

I feel that placing this setting in config.yml is redundant—most checks don't offer additional options, and putting it in config.yml would require two lines of text to disable it.

In punishments.yml, this only requires one line. Besides, it has always been dedicated to configure check on/off settings.

I believe using Permission would draw a small amount of additional overhead—it at least requires access to the cache. And that's designed for a specific player, not globally.

@ManInMyVan

Copy link
Copy Markdown
Contributor

would require two lines of text to disable it.

yml allows this syntax:

MyCheck.enabled: false

@ManInMyVan
ManInMyVan merged commit 6c699c2 into GrimAnticheat:2.0 Jul 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants