-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add event info to sidebar #24589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event info to sidebar #24589
Conversation
linuspahl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed you get an error when replaying a search via the event definitions page
Cannot read properties of undefined (reading 'timestamp')
|
|
||
| if (!validSecurityLicense) { | ||
| // TODO: its for TMP | ||
| if (validSecurityLicense) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed that we need to remove this change before merging
0fdaa3d to
0e80bca
Compare
…into feat/add-event-info-to-sidebar
linuspahl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things I noticed so far:
- When I replay a search I somehow always have a scroll bar
- The hover label looks like this when you are on a different sidebar section
- On the search page the sidebar is now always by default visible and you can't toggle the "pinned" state. When the sidebar is open, it's missing the backdrop.
- When you replay the search for an event definition you don't see the new sidebar action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I try to replay the search for an event, without the enterprise plugin, I get the following error on the replay page:
Cannot read properties of undefined (reading 'useCondition')
I used disable_plugins=true yarn start to run the UI without plugins.
Description
This PR adds a new sidebar section for the event replaying search page. From now on, we will open all replay searches in a separate page with this new sidebar.

Motivation and Context
fix: #24554
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
/prd https://github.com/Graylog2/graylog-plugin-enterprise/pull/12847