Skip to content

Conversation

@maxiadlovskii
Copy link
Contributor

@maxiadlovskii maxiadlovskii commented Dec 19, 2025

Description

This PR adds a new sidebar section for the event replaying search page. From now on, we will open all replay searches in a separate page with this new sidebar.
Screenshot 2026-01-19 at 15 14 33

Motivation and Context

fix: #24554

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

/prd https://github.com/Graylog2/graylog-plugin-enterprise/pull/12847

@maxiadlovskii maxiadlovskii marked this pull request as draft December 19, 2025 07:56
Copy link
Contributor

@linuspahl linuspahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed you get an error when replaying a search via the event definitions page

Cannot read properties of undefined (reading 'timestamp')


if (!validSecurityLicense) {
// TODO: its for TMP
if (validSecurityLicense) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that we need to remove this change before merging

@maxiadlovskii maxiadlovskii force-pushed the feat/add-event-info-to-sidebar branch from 0fdaa3d to 0e80bca Compare January 16, 2026 11:41
@maxiadlovskii maxiadlovskii marked this pull request as ready for review January 19, 2026 14:42
Copy link
Contributor

@linuspahl linuspahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things I noticed so far:

  1. When I replay a search I somehow always have a scroll bar
Image
  1. The hover label looks like this when you are on a different sidebar section
Image
  1. On the search page the sidebar is now always by default visible and you can't toggle the "pinned" state. When the sidebar is open, it's missing the backdrop.
Image
  1. When you replay the search for an event definition you don't see the new sidebar action.

Copy link
Contributor

@linuspahl linuspahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to replay the search for an event, without the enterprise plugin, I get the following error on the replay page:

Cannot read properties of undefined (reading 'useCondition')

I used disable_plugins=true yarn start to run the UI without plugins.

@maxiadlovskii maxiadlovskii added the e2e-tests Run PR build with e2e tests. label Jan 26, 2026
@maxiadlovskii maxiadlovskii merged commit ebcd765 into master Jan 29, 2026
24 of 25 checks passed
@maxiadlovskii maxiadlovskii deleted the feat/add-event-info-to-sidebar branch January 29, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e-tests Run PR build with e2e tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add left event info tray on replay search page

3 participants