Skip to content

Fix SVG renderer not playing animation due to a regression from the tile cache discarding the context#4092

Merged
Keavon merged 1 commit intomasterfrom
fix-svg-renderer-animation
May 2, 2026
Merged

Fix SVG renderer not playing animation due to a regression from the tile cache discarding the context#4092
Keavon merged 1 commit intomasterfrom
fix-svg-renderer-animation

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented May 2, 2026

Fix regression introduced in #3722 that broke animation playback (and Pointer Position render input) in the SVG renderer path.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the render_output_cache function to ensure the existing context is preserved during direct render fallbacks by replacing OwnedContextImpl::empty() with OwnedContextImpl::from(ctx.clone()). It also includes a minor cleanup of an iterator chain by removing an unnecessary into_iter() call. I have no feedback to provide.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@Keavon Keavon merged commit 9943af5 into master May 2, 2026
11 checks passed
@Keavon Keavon deleted the fix-svg-renderer-animation branch May 2, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant