Support relocating Groovy extensions in Module descriptors - #1705
Merged
Conversation
Goooler
changed the title
extensionClasses in Module descriptors
Goooler
force-pushed
the
g/20250831/relocate-groovy-extensions
branch
4 times, most recently
from
September 1, 2025 07:10
fc1dd39 to
3584b84
Compare
1 task
Goooler
force-pushed
the
g/20250831/relocate-groovy-extensions
branch
from
September 1, 2025 07:49
3584b84 to
431bc63
Compare
Goooler
force-pushed
the
g/20250831/relocate-groovy-extensions
branch
2 times, most recently
from
September 2, 2025 09:47
a29bb16 to
810d848
Compare
Goooler
force-pushed
the
g/20250831/relocate-groovy-extensions
branch
from
September 2, 2025 10:00
8425268 to
ade566f
Compare
Goooler
marked this pull request as ready for review
September 2, 2025 10:35
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for relocating Groovy extension class names within Module descriptors when using the shadow plugin. The change ensures that when packages are relocated during shadowing, the Groovy extension module descriptors are updated to reflect the new relocated class names.
Key changes:
- Modified the GroovyExtensionModuleTransformer to apply class relocation to extension class names
- Added comprehensive test coverage for the relocation functionality
- Updated changelog to document the new feature
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| GroovyExtensionModuleTransformer.kt | Implements class name relocation for Groovy extension classes in module descriptors |
| GroovyExtensionModuleTransformerTest.kt | Adds test coverage for relocation functionality and refactors existing test helper |
| README.md | Documents the new feature in the changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #467.