Skip to content

feat(storage): support delete source objects on compose#4360

Open
nidhiii-27 wants to merge 4 commits into
mainfrom
feat/storage-compose-delete-sources
Open

feat(storage): support delete source objects on compose#4360
nidhiii-27 wants to merge 4 commits into
mainfrom
feat/storage-compose-delete-sources

Conversation

@nidhiii-27

Copy link
Copy Markdown
Contributor

Updates compose file sample to support deleting source objects optionally. Fixes b/441557254

Updates compose file sample to support deleting source objects optionally. Fixes b/441557254

[Generated-by: AI]
@nidhiii-27 nidhiii-27 added ai-generated Generated by AI storage-sample-architect Generated by storage-sample-architect skill labels Jun 24, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new sample script 'storage/composeFile.js' to demonstrate how to combine multiple files into a single destination file using the Google Cloud Storage API, along with corresponding integration tests in 'storage/system-test/files.test.js'. The feedback suggests correcting a copy-paste error in the JSDoc header that references Access Control Lists instead of file composition, and dynamically joining the source file names in the console log messages rather than hardcoding them.

Comment thread storage/composeFile.js
Comment thread storage/composeFile.js
Comment thread storage/composeFile.js Outdated
@product-auto-label product-auto-label Bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Jun 24, 2026
@nidhiii-27 nidhiii-27 marked this pull request as ready for review June 24, 2026 13:29
@nidhiii-27 nidhiii-27 requested review from a team as code owners June 24, 2026 13:29
@snippet-bot

snippet-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Generated by AI api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. storage-sample-architect Generated by storage-sample-architect skill

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant