fix(healthcare): set responseType to JSON instead of Buffer in importFhirResources.js

[angelcaamal]

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
• Tests pass: npm test (see Testing)
• Lint pass: npm run lint (see Style)
• Required CI tests pass (see CI testing)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in the FHIR resource import functionality by ensuring that API responses are correctly interpreted as JSON, preventing potential data parsing problems. It also significantly improves the robustness of the import process by introducing a dynamic polling strategy for long-running operations, complete with comprehensive error handling and timeout management, leading to a more reliable and user-friendly experience.

Highlights

• API Client Configuration: Configured the healthcare client to explicitly set the responseType to json, ensuring proper parsing of API responses.
• Long-Running Operation (LRO) Polling: Implemented a dynamic polling mechanism for FHIR resource import operations, replacing a fixed wait with periodic status checks every 5 seconds until completion or timeout.
• Error Handling: Enhanced error handling for the import process by wrapping the operation in a try-catch block and adding specific checks for operation failures and timeouts.

Changelog

• healthcare/fhir/importFhirResources.js
  • Set the responseType for the Google Auth client to json.
  • Refactored the long-running operation (LRO) polling logic to dynamically check status instead of a fixed wait.
  • Added comprehensive error handling for the import process, including try-catch and specific checks for operation errors and timeouts.

Activity

• No specific activity (comments, reviews, progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly sets the responseType to json and significantly improves the robustness of the FHIR resource import logic by replacing a fixed-delay wait with a proper polling mechanism for the long-running operation. This includes better error handling and a timeout, which is a great improvement. I have one piece of feedback regarding a potential TypeError when accessing a nested property, for which I've provided a suggested fix.