Skip to content

Migrate resource_compute_instance_group_manager.go.tmpl to use transport_tpg.SendRequest - part 2#17286

Draft
iliatsuprik wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
iliatsuprik:igm-migrate-read
Draft

Migrate resource_compute_instance_group_manager.go.tmpl to use transport_tpg.SendRequest - part 2#17286
iliatsuprik wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
iliatsuprik:igm-migrate-read

Conversation

@iliatsuprik
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

This change migrates resourceComputeInstanceGroupManagerRead and relevant functions only. Other functionality will be migrated in next PRs

compute: migrated `resource_compute_instance_group_manager.go.tmpl` resource to use direct HTTP rather than a client library

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 736 insertions(+), 64 deletions(-))
google-beta provider: Diff ( 1 file changed, 776 insertions(+), 65 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1420
Passed tests: 1301
Skipped tests: 91
Affected tests: 28

Click here to see the affected service packages
  • compute

Action taken

Found 28 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeAutoscaler_autoscalerBasicExample
  • TestAccComputeAutoscaler_autoscalerSingleInstanceExample
  • TestAccComputeBackendService_withBackend
  • TestAccComputeBackendService_withBackendAndIAP
  • TestAccComputeBackendService_withBackendAndMaxUtilization
  • TestAccComputeBackendService_withBackendAndPreferenceExternalManaged
  • TestAccComputeBackendService_withBackendAndPreferenceInternalManaged
  • TestAccComputeBackendService_withBackendAndPreferenceInternalSelfManaged
  • TestAccComputeBackendService_withMaxConnections
  • TestAccComputeBackendService_withMaxConnectionsPerInstance
  • TestAccComputeBackendService_withMaxInFlightRequests
  • TestAccComputeBackendService_withMaxInFlightRequestsPerInstance
  • TestAccComputeBackendService_withTrafficDuration
  • TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample
  • TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample
  • TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample
  • TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample
  • TestAccComputeGlobalForwardingRule_internalLoadBalancing
  • TestAccComputeRegionBackendService_withBackendInternal
  • TestAccComputeRegionBackendService_withBackendMultiNic
  • TestAccComputeRegionBackendService_withMaxInFlightRequests
  • TestAccComputeRegionBackendService_withMaxInFlightRequestsPerInstance
  • TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy
  • TestAccComputeRegionBackendService_withTrafficDuration
  • TestAccComputeResizeRequest_computeMigResizeRequestExample
  • TestAccDataSourceGoogleComputeInstanceGroupManager
  • TestAccDataSourceGoogleComputeInstanceGroup_fromIGM
  • TestAccInstanceGroupManager_versions

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeAutoscaler_autoscalerBasicExample [Debug log]
TestAccComputeAutoscaler_autoscalerSingleInstanceExample [Debug log]
TestAccComputeBackendService_withBackend [Debug log]
TestAccComputeBackendService_withBackendAndIAP [Debug log]
TestAccComputeBackendService_withBackendAndMaxUtilization [Debug log]
TestAccComputeBackendService_withBackendAndPreferenceExternalManaged [Debug log]
TestAccComputeBackendService_withBackendAndPreferenceInternalManaged [Debug log]
TestAccComputeBackendService_withBackendAndPreferenceInternalSelfManaged [Debug log]
TestAccComputeBackendService_withMaxConnections [Debug log]
TestAccComputeBackendService_withMaxConnectionsPerInstance [Debug log]
TestAccComputeBackendService_withMaxInFlightRequests [Debug log]
TestAccComputeBackendService_withMaxInFlightRequestsPerInstance [Debug log]
TestAccComputeBackendService_withTrafficDuration [Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample [Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample [Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample [Debug log]
TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample [Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing [Debug log]
TestAccComputeRegionBackendService_withBackendInternal [Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic [Debug log]
TestAccComputeRegionBackendService_withMaxInFlightRequests [Debug log]
TestAccComputeRegionBackendService_withMaxInFlightRequestsPerInstance [Debug log]
TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Debug log]
TestAccComputeRegionBackendService_withTrafficDuration [Debug log]
TestAccComputeResizeRequest_computeMigResizeRequestExample [Debug log]
TestAccDataSourceGoogleComputeInstanceGroupManager [Debug log]
TestAccDataSourceGoogleComputeInstanceGroup_fromIGM [Debug log]
TestAccInstanceGroupManager_versions [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants