Skip to content

dns: add list resource for google_dns_record_set#17263

Open
malhotrasagar2212 wants to merge 7 commits intoGoogleCloudPlatform:mainfrom
malhotrasagar2212:list_support_google_dns_record_set
Open

dns: add list resource for google_dns_record_set#17263
malhotrasagar2212 wants to merge 7 commits intoGoogleCloudPlatform:mainfrom
malhotrasagar2212:list_support_google_dns_record_set

Conversation

@malhotrasagar2212
Copy link
Copy Markdown
Collaborator

@malhotrasagar2212 malhotrasagar2212 commented Apr 23, 2026

Added List resource and resource identity support to google_dns_record_set

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

dns: add list resource for `google_dns_record_set`
dns: add resource identity support for `google_dns_record_set` resource

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 366 insertions(+))
google-beta provider: Diff ( 5 files changed, 366 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 6345
Passed tests: 5674
Skipped tests: 652
Affected tests: 19

Click here to see the affected service packages

All service packages are affected

Action taken

Found 19 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCESApp_update
  • TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample
  • TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_updateVersion
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDNSRecordSetListResource_queryIdentity
  • TestAccDNSRecordSet_changeType
  • TestAccDNSRecordSet_importBlockWithResourceIdentity
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

Copy link
Copy Markdown
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking do not merge until hashicorp/terraform-provider-google#27055 is resolved

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDNSRecordSetListResource_queryIdentity [Debug log]
TestAccDNSRecordSet_importBlockWithResourceIdentity [Debug log]
TestAccProjectIamMemberRemove_memberInMultipleBindings [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCESApp_update [Error message] [Debug log]
TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample [Error message] [Debug log]
TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccContainerCluster_updateVersion [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccContainerNodePool_withHostMaintenancePolicy [Error message] [Debug log]
TestAccDNSRecordSet_changeType [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants