fix(ces): make engine optional in DataStoreTool engineSource#17261
fix(ces): make engine optional in DataStoreTool engineSource#17261msvechla wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
The CES API accepts engineSource.dataStoreSources without specifying an engine. When engine is omitted, CES automatically uses its internally managed engine for the app, which is the same behavior as creating a data store tool via the CES console UI. This unblocks use cases where users want to reference a data store directly without managing a separate engine resource.
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 51 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 51 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Summary
The
enginefield insideDataStoreTool.engineSourceis currently marked asrequired: truein the Terraform provider schema. However, the CES API acceptsengineSourcewith onlydataStoreSourcesand noenginespecified — in this case CES automatically uses its internally managed engine for the app.This matches the behavior of creating a data store tool via the CES console UI, which produces an
engineSourceblock with onlydataStoreSourcesand noenginefield.Marking
engineas optional (removingrequired: true) allows users to reference a data store directly without needing to manage a separate Discovery Engine resource, which is the common use case when linking a data store to a CES app via Terraform.Changes
mmv1/products/ces/Tool.yaml: Removerequired: truefromenginefield inDataStoreTool.engineSourceNotes
engineset continue to work unchangedces_tool_data_store_tool_engine_source_basic) still usesengineand remains valid