feat(compute): Add storage_pool support to instance template disks#16571
Open
yihanl-google wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Open
feat(compute): Add storage_pool support to instance template disks#16571yihanl-google wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
yihanl-google wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
Adds support for the 'storage_pool' attribute within the 'disk' block for both google_compute_instance_template and google_compute_region_instance_template resources. Includes acceptance tests for both resources. Fixes b/475522051
modular-magician
added
the
awaiting-approval
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the 'storage_pool' attribute within the 'disk' block for both google_compute_instance_template and
google_compute_region_instance_template resources.
Includes acceptance tests for both resources.
The following acceptance tests: TestAccComputeInstanceTemplate_storagePool and TestAccComputeRegionInstanceTemplate_storagePool have been executed successfully.
Fixes b/475522051
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.