compute: convert service_attachment_test.go file to .go.tmpl#16555
Open
BBBmau wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Open
compute: convert service_attachment_test.go file to .go.tmpl#16555BBBmau wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
compute: convert service_attachment_test.go file to .go.tmpl#16555BBBmau wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
Tests analyticsTotal tests: 1367 Click here to see the affected service packages
🟢 All tests passed! View the build log |
hao-nan-li
approved these changes
Feb 26, 2026
Member
|
Thanks for the fix. |
Member
|
@BBBmau and @hao-nan-li should we merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This conversion is from #16493
the PR introduced a beta only field but the test file itself is a regular go file resulting in the nightly test running the field on both GA and beta instead of just beta.
Having it a
.go.tmplwill allow us to prevent the test on the beta only field to be generated ongoogle-betaTeamCity Build which shows the error from using field in GA provider
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.