Add allowed_values_regex field to google_tags_tag_key resource

[amukul-25]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

tags: added `allowed_values_regex` field to `google_tags_tag_key` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 311 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 12 files changed, 311 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 19 insertions(+))

[modular-magician]

Tests analytics

Total tests: 5895
Passed tests: 5267
Skipped tests: 608
Affected tests: 20

Click here to see the affected service packages

All service packages are affected

Action taken

Found 20 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAccessContextManager__gcp_user_access_binding
• TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
• TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy
• TestAccComputeFutureReservation_futureReservationAggregateReservationExample
• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccContainerCluster_networkPerformanceConfig
• TestAccContainerCluster_withTPUConfig
• TestAccContainerCluster_withTpu
• TestAccContainerNodePool_secondaryBootDisks
• TestAccDataFusionInstance_dataFusionInstanceCmekExample
• TestAccDataSourceGoogleTagsTagKey_withRegex
• TestAccDataSourceGoogleTagsTagKeys_withRegex
• TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample
• TestAccDialogflowCXTestCase_update
• TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update
• TestAccGKEHubFeature_FleetDefaultMemberConfigPolicyController
• TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
• TestAccSqlDatabaseInstance_activationPolicy
• TestAccTags__tagKeyBasicWithAllowedValuesRegex
• TestAccTags__tagKeyUpdateAllowedValuesRegex

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccTags__tagBindingBasic [Debug log]
TestAccTags__tagKeyBasic [Debug log]
TestAccTags__tagKeyBasicWithPurposeDataGovernance [Debug log]
TestAccTags__tagKeyBasicWithPurposeGceFirewall [Debug log]
TestAccTags__tagKeyIamBinding [Debug log]
TestAccTags__tagKeyIamMember [Debug log]
TestAccTags__tagKeyIamPolicy [Debug log]
TestAccTags__tagKeyUpdate [Debug log]
TestAccTags__tagValueBasic [Debug log]
TestAccTags__tagValueIamBinding [Debug log]
TestAccTags__tagValueIamMember [Debug log]
TestAccTags__tagValueIamPolicy [Debug log]
TestAccTags__tagValueUpdate [Debug log]
TestAccTags__tagsLocationTagBindingBasic [Debug log]
TestAccTags__tagsLocationTagBindingZonal [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccComputeFutureReservation_futureReservationAggregateReservationExample [Error message] [Debug log]
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]
TestAccContainerCluster_networkPerformanceConfig [Error message] [Debug log]
TestAccContainerCluster_withTPUConfig [Error message] [Debug log]
TestAccContainerCluster_withTpu [Error message] [Debug log]
TestAccContainerNodePool_secondaryBootDisks [Error message] [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Error message] [Debug log]
TestAccDataSourceGoogleTagsTagKey_withRegex [Error message] [Debug log]
TestAccDataSourceGoogleTagsTagKeys_withRegex [Error message] [Debug log]
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update [Error message] [Debug log]
TestAccGKEHubFeature_FleetDefaultMemberConfigPolicyController [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]
TestAccSqlDatabaseInstance_activationPolicy [Error message] [Debug log]
TestAccTags__tagKeyBasicWithAllowedValuesRegex [Error message] [Debug log]
TestAccTags__tagKeyUpdateAllowedValuesRegex [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[zli82016]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 311 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 12 files changed, 311 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 19 insertions(+))

[modular-magician]

Tests analytics

Total tests: 5900
Passed tests: 5269
Skipped tests: 610
Affected tests: 21

Click here to see the affected service packages

All service packages are affected

Action taken

Found 21 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAccessContextManager__gcp_user_access_binding
• TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
• TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy
• TestAccBackupDRBackupPlan_backupDrBackupPlanForDiskResourceExample
• TestAccComputeFutureReservation_futureReservationAggregateReservationExample
• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccContainerCluster_networkPerformanceConfig
• TestAccContainerCluster_withTPUConfig
• TestAccContainerCluster_withTpu
• TestAccContainerNodePool_nestedVirtualization
• TestAccContainerNodePool_secondaryBootDisks
• TestAccDataFusionInstance_dataFusionInstanceCmekExample
• TestAccDataSourceGoogleTagsTagKey_withRegex
• TestAccDataSourceGoogleTagsTagKeys_withRegex
• TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample
• TestAccDialogflowCXTestCase_update
• TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update
• TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
• TestAccSqlDatabaseInstance_activationPolicy
• TestAccTags__tagKeyBasicWithAllowedValuesRegex
• TestAccTags__tagKeyUpdateAllowedValuesRegex

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccBackupDRBackupPlan_backupDrBackupPlanForDiskResourceExample [Debug log]
TestAccContainerNodePool_nestedVirtualization [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update [Debug log]
TestAccTags__tagBindingBasic [Debug log]
TestAccTags__tagKeyBasic [Debug log]
TestAccTags__tagKeyBasicWithPurposeDataGovernance [Debug log]
TestAccTags__tagKeyBasicWithPurposeGceFirewall [Debug log]
TestAccTags__tagKeyIamBinding [Debug log]
TestAccTags__tagKeyIamMember [Debug log]
TestAccTags__tagKeyIamPolicy [Debug log]
TestAccTags__tagKeyUpdate [Debug log]
TestAccTags__tagValueBasic [Debug log]
TestAccTags__tagValueIamBinding [Debug log]
TestAccTags__tagValueIamMember [Debug log]
TestAccTags__tagValueIamPolicy [Debug log]
TestAccTags__tagValueUpdate [Debug log]
TestAccTags__tagsLocationTagBindingBasic [Debug log]
TestAccTags__tagsLocationTagBindingZonal [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level_condition [Error message] [Debug log]
TestAccAccessContextManager__access_level_custom [Error message] [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Error message] [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccComputeFutureReservation_futureReservationAggregateReservationExample [Error message] [Debug log]
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]
TestAccContainerCluster_networkPerformanceConfig [Error message] [Debug log]
TestAccContainerCluster_withTPUConfig [Error message] [Debug log]
TestAccContainerCluster_withTpu [Error message] [Debug log]
TestAccContainerNodePool_secondaryBootDisks [Error message] [Debug log]
TestAccDataSourceGoogleTagsTagKey_withRegex [Error message] [Debug log]
TestAccDataSourceGoogleTagsTagKeys_withRegex [Error message] [Debug log]
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]
TestAccSqlDatabaseInstance_activationPolicy [Error message] [Debug log]
TestAccTags__tagKeyBasicWithAllowedValuesRegex [Error message] [Debug log]
TestAccTags__tagKeyUpdateAllowedValuesRegex [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[malhotrasagar2212]

@amukul-25 Could you please check the failing PR related tests. Thanks.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 311 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 12 files changed, 311 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 19 insertions(+))

[modular-magician]

Tests analytics

Total tests: 5923
Passed tests: 5284
Skipped tests: 633
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
• TestAccDataFusionInstance_dataFusionInstanceCmekExample
• TestAccDataSourceGoogleTagsTagKey_withRegex
• TestAccDataSourceGoogleTagsTagKeys_withRegex
• TestAccTags__tagKeyBasicWithAllowedValuesRegex
• TestAccTags__tagKeyUpdateAllowedValuesRegex

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Debug log]
TestAccTags__tagBindingBasic [Debug log]
TestAccTags__tagKeyBasic [Debug log]
TestAccTags__tagKeyBasicWithPurposeDataGovernance [Debug log]
TestAccTags__tagKeyBasicWithPurposeGceFirewall [Debug log]
TestAccTags__tagKeyIamBinding [Debug log]
TestAccTags__tagKeyIamMember [Debug log]
TestAccTags__tagKeyIamPolicy [Debug log]
TestAccTags__tagKeyUpdate [Debug log]
TestAccTags__tagValueBasic [Debug log]
TestAccTags__tagValueIamBinding [Debug log]
TestAccTags__tagValueIamMember [Debug log]
TestAccTags__tagValueIamPolicy [Debug log]
TestAccTags__tagValueUpdate [Debug log]
TestAccTags__tagsLocationTagBindingBasic [Debug log]
TestAccTags__tagsLocationTagBindingZonal [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__service_perimeters [Error message] [Debug log]
TestAccDataSourceGoogleTagsTagKey_withRegex [Error message] [Debug log]
TestAccDataSourceGoogleTagsTagKeys_withRegex [Error message] [Debug log]
TestAccTags__tagKeyBasicWithAllowedValuesRegex [Error message] [Debug log]
TestAccTags__tagKeyUpdateAllowedValuesRegex [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[amukul-25]

@amukul-25 Could you please check the failing PR related tests. Thanks.

@malhotrasagar2212 The failing tests are currently due to Terraform org not allowlisted by the backend Prod service, I'm working on allowlisting the concerned org id in prod. REf error - Error: Error creating TagKey: googleapi: Error 400: Parent 'organizations/529579013760' is not allowlisted for creating/updating dynamic tag values.

Meanwhile can you please review the code changes and let me know if any changes are required.

[rileykarson]

Moving reviewer to @slevenick who's working the the contributor internally, since we may use local run logs to prove the feature works in parallel w/ allowlisting

@modular-magician reassign-reviewer @slevenick

[slevenick]

This looks totally reasonable. Let's sync on how and when to merge & release this, but I don't have concerns about the code

[github-actions]

@slevenick This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.