Skip to content

Conversation

@NickElliot
Copy link
Contributor

@NickElliot NickElliot commented Dec 18, 2025

was reached out to by a service team regarding hashicorp/terraform-provider-google#25577 hashicorp/terraform-provider-google#25576 hashicorp/terraform-provider-google#25523 where the flakiness seemed to be caused by these tests being ran in parallel. rather than recreating all the tests as handwritten, this feels like a straight forward solution for long term maintainability.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@NickElliot NickElliot changed the title adding a flag to deserialize generated tests adding a flag to serialize generated tests Dec 18, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 4 deletions(-))

@NickElliot
Copy link
Contributor Author

@modular-magician reassign-reviewer

@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from roaks3 December 18, 2025 22:10
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • firebaseapphosting

🟢 All tests passed!

View the build log

@NickElliot
Copy link
Contributor Author

tests dont actually need changes per yaqs/7977712224003162112, but I think this still would be a useful thing to have

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me (might want to raise with the team as a change to the mm interface). The one thing I would mention just in case it's worth calling out: I believe in most test environments we run a separate go test per product, so the serial behavior would only apply within a particular product (ie. tests from other products could be running at the same time).

@github-actions
Copy link

@roaks3 This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

@roaks3 This PR is approved and has been waiting for merge for 2 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

@roaks3 This PR is approved and has been waiting for merge for 3 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link

@roaks3 This PR is approved and has been waiting for merge for 4 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link

@roaks3 This PR is approved and has been waiting for merge for 5 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link

@roaks3 This PR is approved and has been waiting for merge for 6 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants