-
Notifications
You must be signed in to change notification settings - Fork 2.1k
adding a flag to serialize generated tests #15996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@modular-magician reassign-reviewer |
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: 13 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
tests dont actually need changes per yaqs/7977712224003162112, but I think this still would be a useful thing to have |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
roaks3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me (might want to raise with the team as a change to the mm interface). The one thing I would mention just in case it's worth calling out: I believe in most test environments we run a separate go test per product, so the serial behavior would only apply within a particular product (ie. tests from other products could be running at the same time).
|
@roaks3 This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label |
|
@roaks3 This PR is approved and has been waiting for merge for 2 weeks. Is it ready to merge? Use the label |
|
@roaks3 This PR is approved and has been waiting for merge for 3 weeks. Is it ready to merge? Use the label |
|
@roaks3 This PR is approved and has been waiting for merge for 4 weeks. Is it ready to merge? Use the label |
|
@roaks3 This PR is approved and has been waiting for merge for 5 weeks. Is it ready to merge? Use the label |
|
@roaks3 This PR is approved and has been waiting for merge for 6 weeks. Is it ready to merge? Use the label |
was reached out to by a service team regarding hashicorp/terraform-provider-google#25577 hashicorp/terraform-provider-google#25576 hashicorp/terraform-provider-google#25523 where the flakiness seemed to be caused by these tests being ran in parallel. rather than recreating all the tests as handwritten, this feels like a straight forward solution for long term maintainability.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.