Add Dialogflow Environment Resource #15990

Spheny1 · 2025-12-18T14:24:37Z

Add support for Dialogflow Environment.
Release Note Template for Downstream PRs (will be copied)

`google_dialogflow_environment`

github-actions · 2025-12-18T14:25:38Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-12-18T22:19:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1791 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1791 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 454 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_environment (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_environment" "primary" {
  fulfillment {
    display_name = # value needed
    features {
      type = # value needed
    }
    generic_web_service {
      password        = # value needed
      request_headers = # value needed
      uri             = # value needed
      username        = # value needed
    }
    name = # value needed
  }
  location = # value needed
  text_to_speech_settings {
    output_audio_encoding = # value needed
    synthesize_speech_configs {
      volume_gain_db = # value needed
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

google_dialogflow_environment

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2025-12-18T22:27:37Z

Tests analytics

Total tests: 18
Passed tests: 16
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

dialogflow

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample

TestAccDialogflowEnvironment_update

Get to know how VCR tests work

modular-magician · 2025-12-18T22:30:57Z

🟢 Tests passed during RECORDING mode:
TestAccDialogflowEnvironment_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

NickElliot

test is failing due to this unclosed string

mmv1/templates/terraform/examples/dialogflow_environment_basic.tf.tmpl

….tf.tmpl

modular-magician · 2025-12-22T21:21:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1791 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1791 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 454 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_environment (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_environment" "primary" {
  fulfillment {
    display_name = # value needed
    features {
      type = # value needed
    }
    generic_web_service {
      password        = # value needed
      request_headers = # value needed
      uri             = # value needed
      username        = # value needed
    }
    name = # value needed
  }
  location = # value needed
  text_to_speech_settings {
    output_audio_encoding = # value needed
    synthesize_speech_configs {
      volume_gain_db = # value needed
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

google_dialogflow_environment

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2025-12-22T21:29:40Z

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

dialogflow

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample

Get to know how VCR tests work

modular-magician · 2025-12-22T21:31:26Z

🔴 Tests failed during RECORDING mode:
TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Spheny1 · 2025-12-23T18:53:11Z

What is the new error that this throwing clicking on the link gives me a 403 error and I have this working locally so I am not sure what I need to do.

zli82016 · 2025-12-23T22:01:53Z

/gcbrun

modular-magician · 2025-12-23T22:15:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1791 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1791 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 454 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_environment (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_environment" "primary" {
  fulfillment {
    display_name = # value needed
    features {
      type = # value needed
    }
    generic_web_service {
      password        = # value needed
      request_headers = # value needed
      uri             = # value needed
      username        = # value needed
    }
    name = # value needed
  }
  location = # value needed
  text_to_speech_settings {
    output_audio_encoding = # value needed
    synthesize_speech_configs {
      volume_gain_db = # value needed
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

google_dialogflow_environment

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2025-12-23T22:23:02Z

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

dialogflow

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample

Get to know how VCR tests work

modular-magician · 2025-12-23T22:24:43Z

🔴 Tests failed during RECORDING mode:
TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2025-12-25T09:44:10Z

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-12-29T09:47:57Z

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2026-01-05T09:49:39Z

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

NickElliot

test is failing with the following!

Error: Error creating Environment: googleapi: Error 400: com.google.apps.framework.request.BadRequestException: Agent version should be specified in the environment.

Spheny1 · 2026-01-07T06:35:39Z

test is failing with the following!

Error: Error creating Environment: googleapi: Error 400: com.google.apps.framework.request.BadRequestException: Agent version should be specified in the environment.

Is there anyway to see what value is being passed on the CI build? running this locally with debug it is giving me the value I would expect to see.

github-actions · 2026-01-09T09:46:46Z

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

NickElliot

---[ REQUEST ]---------------------------------------
POST /v2/projects/ci-test-project-[...]/locations/global/agent/environments/?alt=json&environmentId=basic-environment HTTP/1.1
Host: dialogflow.googleapis.com
User-Agent: Terraform/1.11.0 (+https://www.terraform.io) Terraform-Plugin-SDK/2.38.1 terraform-provider-google-beta/acc
Content-Length: 36
Content-Type: application/json
Accept-Encoding: gzip

{
 "description": "basic environment"
}

-----------------------------------------------------
2025/12/23 22:24:30 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------
HTTP/2.0 400 Bad Request
Content-Type: application/json; charset=UTF-8
Date: Tue, 23 Dec 2025 22:24:30 GMT
Server: ESF
Vary: Origin
Vary: X-Origin
Vary: Referer
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 0

{
  "error": {
    "code": 400,
    "message": "com.google.apps.framework.request.BadRequestException: Agent version should be specified in the environment.",
    "status": "INVALID_ARGUMENT"
  }
}

This is the request that is encountering an error, can you share your debug log with any personal info redacted?

modular-magician · 2026-01-20T21:20:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1803 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1803 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 454 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_environment (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_environment" "primary" {
  fulfillment {
    display_name = # value needed
    features {
      type = # value needed
    }
    generic_web_service {
      password        = # value needed
      request_headers = # value needed
      uri             = # value needed
      username        = # value needed
    }
    name = # value needed
  }
  location = # value needed
  text_to_speech_settings {
    output_audio_encoding = # value needed
    synthesize_speech_configs {
      volume_gain_db = # value needed
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

google_dialogflow_environment

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2026-01-20T21:29:42Z

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

dialogflow

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample

Get to know how VCR tests work

modular-magician · 2026-01-20T21:29:58Z

🔴 Tests failed during RECORDING mode:
TestAccDialogflowEnvironment_dialogflowEnvironmentBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2026-01-21T09:49:31Z

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

NickElliot

you still have unclosed strings in these!

resource_dialogflow_environment_generated_test.go:62: Step 1/2 error: Error running pre-apply refresh: exit status 1

    Error: Invalid multi-line string
    
      on terraform_plugin_test.tf line 39, in resource "google_dialogflow_environment" "basic_environment":
      39:   description = "basic environment
      40:   depends_on = [google_dialogflow_agent.basic_agent]
    
    Quoted strings may not be split over multiple lines. To produce a multi-line
    string, either use the \n escape to represent a newline character or use the
    "heredoc" multi-line template syntax.

NickElliot · 2026-01-22T19:45:09Z

mmv1/templates/terraform/examples/dialogflow_environment_basic.tf.tmpl

+}
+resource "google_dialogflow_environment" "basic_environment" {
+  environmentid = "basic-environment"
+  description = "basic environment


Spheny1 added 3 commits December 16, 2025 13:49

Add files via upload

b8f80eb

Add files via upload

de83f22

Add files via upload

055a6a0

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 18, 2025

github-actions bot requested a review from NickElliot December 18, 2025 14:25

Spheny1 added 2 commits December 18, 2025 11:00

Update Environment.yaml

8956876

Update Environment.yaml

fb3f16a

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 18, 2025

NickElliot requested changes Dec 22, 2025

View reviewed changes

mmv1/templates/terraform/examples/dialogflow_environment_basic.tf.tmpl Outdated Show resolved Hide resolved

Update mmv1/templates/terraform/examples/dialogflow_environment_basic…

491ea75

….tf.tmpl

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 22, 2025

github-actions bot requested a review from NickElliot December 22, 2025 21:10

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 22, 2025

modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Dec 23, 2025

NickElliot requested changes Jan 6, 2026

View reviewed changes

github-actions bot requested a review from NickElliot January 7, 2026 06:36

NickElliot reviewed Jan 12, 2026

View reviewed changes

Update dialogflow_environment_basic.tf.tmpl

b344ba8

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 16, 2026

github-actions bot requested a review from NickElliot January 16, 2026 19:41

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 20, 2026

NickElliot requested changes Jan 22, 2026

View reviewed changes

Update dialogflow_environment_basic.tf.tmpl

91c6737

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 28, 2026

github-actions bot requested a review from NickElliot January 28, 2026 04:21

Merge branch 'GoogleCloudPlatform:main' into main

4ed23d4

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 28, 2026

Add Dialogflow Environment Resource #15990

Are you sure you want to change the base?

Add Dialogflow Environment Resource #15990

Conversation

Spheny1 commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

modular-magician commented Dec 18, 2025

Diff report

Missing test report

Missing service labels

Uh oh!

modular-magician commented Dec 18, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 18, 2025

Uh oh!

NickElliot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

modular-magician commented Dec 22, 2025

Diff report

Missing test report

Missing service labels

Uh oh!

modular-magician commented Dec 22, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 22, 2025

Uh oh!

Spheny1 commented Dec 23, 2025

Uh oh!

zli82016 commented Dec 23, 2025

Uh oh!

modular-magician commented Dec 23, 2025

Diff report

Missing test report

Missing service labels

Uh oh!

modular-magician commented Dec 23, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 23, 2025

Uh oh!

github-actions bot commented Dec 25, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

NickElliot left a comment

Choose a reason for hiding this comment

Uh oh!

Spheny1 commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 9, 2026

Uh oh!

NickElliot left a comment

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Jan 20, 2026

Diff report

Missing test report

Missing service labels

Uh oh!

modular-magician commented Jan 20, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 20, 2026

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

NickElliot left a comment

Spheny1 commented Jan 7, 2026 •

edited

Loading