FIX: allow update ipv6 without recreation #15989

victorsantos-cit · 2025-12-18T13:16:43Z

Hello Folks.
This PR is to fix hashicorp/terraform-provider-google#25324

Release Note Template for Downstream PRs (will be copied)

compute: update `external_ipv6`.`ForceNew` to `false` on `google_compute_instance` resource

Add acceptance test for Compute Instance with IPv6 external address handling.

github-actions · 2025-12-18T13:17:41Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

roaks3

Some minor suggestions, running tests now...

roaks3 · 2025-12-19T22:22:27Z

mmv1/third_party/terraform/services/compute/resource_compute_instance.go.tmpl

 										Optional:         true,
 										Computed:         true,
-										ForceNew:         true,
+										ForceNew:         false,


Could you just remove this line? (false is the default)

roaks3 · 2025-12-19T22:22:43Z

mmv1/third_party/terraform/services/compute/resource_compute_instance_template_test.go.tmpl

+				),
+			},
+			{
+				// troca de IPv6 → recreate obrigatório


Could you remove this, or change to english?

mmv1/third_party/terraform/services/compute/resource_compute_instance_template_test.go.tmpl

modular-magician · 2025-12-19T22:39:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 109 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 109 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  network_interface {
    ipv6_access_config {
      external_ipv6 = # value needed
    }
  }
}

Resource: google_compute_instance_from_template (24 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  network_interface {
    ipv6_access_config {
      external_ipv6 = # value needed
    }
  }
}

modular-magician · 2025-12-19T23:09:26Z

Tests analytics

Total tests: 1319
Passed tests: 1232
Skipped tests: 84
Affected tests: 3

Click here to see the affected service packages

compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFutureReservation_sharedFutureReservationExample

TestAccComputeInstance_IPv6ExternalRecreate

TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy

Get to know how VCR tests work

modular-magician · 2025-12-19T23:16:34Z

🟢 Tests passed during RECORDING mode:
TestAccComputeInstance_IPv6ExternalRecreate [Debug log]
TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Removed comment regarding IPv6 recreation requirement.

roaks3

Still just waiting on PlanCheck

victorsantos-cit · 2025-12-26T17:42:09Z

@roaks3 I finish the plancheck , please, take a look for me

github-actions · 2025-12-31T09:45:06Z

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2026-01-02T09:45:01Z

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

victorsantos-cit · 2026-01-02T14:51:07Z

@roaks3 Hey , could you review this PR please

victorsantos-cit · 2026-01-05T14:58:03Z

@roaks3 Hey , could you review this PR please

victorsantos-cit · 2026-01-06T17:03:42Z

@roaks3 Hey , could you review this PR please

roaks3 · 2026-01-06T17:12:14Z

@victorsantos-cit respectfully, please stop spamming PRs to get a response, the automation already does that for us. Also note that there are US holidays at the end of the year where large numbers of employees are out of office and slower to respond.

victorsantos-cit · 2026-01-06T17:13:42Z

@roaks3 sorry about that

roaks3 · 2026-01-07T17:56:16Z

mmv1/third_party/terraform/services/compute/resource_compute_instance_template_test.go.tmpl

 }
 {{- end }}

+func TestAccComputeInstance_IPv6ExternalRecreate(t *testing.T) {


I'm confused about this test in its current state:

Isn't the change here meant to prevent recreation when this value is changed?

Why is the plan check ensuring that the resource is recreated?

hey @roaks3 , one question, on the logs in this task , the resource was created ?
Because make the analisy in the log, i dont find nothing show the resource was delete and recreated , and that is the focus on this issue, right ?

So if you use TF_LOG=DEBUG you'll get the API requests, which should highlight somewhat if there are new delete/post requests during update. But the nicer way we use now is the plan check (see https://googlecloudplatform.github.io/magic-modules/test/test/#add-an-update-test, specifically plancheck.ResourceActionUpdate), which basically allows you to verify that Terraform did an in-place update.

As written, I think your test confirms that the resource is recreated instead of updated in-place.

i thinkin here, one question, make the analise in the api, you could confirm if this action to update the resource, is abble ? because this field is immutable, so i'm think if this update makes sense

@roaks3 , i thinkin here, one question, make the analise in the api, you could confirm if this action to update the resource, is abble ? because this field is immutable, so i'm think if this update makes sense

I'm confused by the comment, could you rephrase? This PR seems to imply that the field is mutable (on the API).

My question is whether the API and Terraform allow this request, coming from the issue, given that this implementation involves network resources.

According to hashicorp/terraform-provider-google#25324, it looks like you might need to call a special endpoint for updating this field.

victorsantos-cit · 2026-01-17T01:13:59Z

Do you know what is the name of this endpoint ?

…

On Fri, 16 Jan 2026 at 17:40 Ryan Oaks ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In mmv1/third_party/terraform/services/compute/resource_compute_instance_template_test.go.tmpl <#15989 (comment)> : > @@ -1577,6 +1578,118 @@ func TestAccComputeInstanceTemplate_partnerMetadata(t *testing.T) { } {{- end }} +func TestAccComputeInstance_IPv6ExternalRecreate(t *testing.T) { According to hashicorp/terraform-provider-google#25324 <hashicorp/terraform-provider-google#25324>, it looks like you might need to call a special endpoint for updating this field. — Reply to this email directly, view it on GitHub <#15989 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BUFA4HFQBXX476U23YXBIGT4HFEDBAVCNFSM6AAAAACPNW7CESVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNZSGY2TIOJRGY> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

-- This email contains confidential information and is intended solely for the recipient named above. If you have received this email in error, please delete it immediately and notify the sender. The unauthorized dissemination, distribution, or copying of this email and its contents are strictly prohibited.

github-actions · 2026-01-21T09:49:33Z

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2026-01-23T09:48:22Z

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

victorsantos-cit added 2 commits December 18, 2025 10:11

Implement acceptance test for IPv6 external address

bc29c46

Add acceptance test for Compute Instance with IPv6 external address handling.

Change ForceNew for external_ipv6 to false

b826db5

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 18, 2025

github-actions bot requested a review from roaks3 December 18, 2025 13:17

roaks3 reviewed Dec 19, 2025

View reviewed changes

modular-magician added service/compute-instances and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Dec 19, 2025

Remove IPv6 recreation comment from test template

6b8bbf6

Removed comment regarding IPv6 recreation requirement.

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 22, 2025

Remove ForceNew attribute from external_ipv6

ca1fdaa

github-actions bot requested a review from roaks3 December 22, 2025 18:22

roaks3 reviewed Dec 23, 2025

View reviewed changes

Add plan checks to compute instance template tests

5ee71ee

github-actions bot requested a review from roaks3 December 26, 2025 17:41

roaks3 reviewed Jan 7, 2026

View reviewed changes

github-actions bot requested a review from roaks3 January 17, 2026 01:15

victorsantos-cit closed this Jan 27, 2026

FIX: allow update ipv6 without recreation #15989

FIX: allow update ipv6 without recreation #15989

Conversation

victorsantos-cit commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

roaks3 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

modular-magician commented Dec 19, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Dec 19, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 19, 2025

Uh oh!

roaks3 left a comment

Choose a reason for hiding this comment

Uh oh!

victorsantos-cit commented Dec 26, 2025

Uh oh!

github-actions bot commented Dec 31, 2025

Uh oh!

github-actions bot commented Jan 2, 2026

Uh oh!

victorsantos-cit commented Jan 2, 2026

Uh oh!

victorsantos-cit commented Jan 5, 2026

Uh oh!

victorsantos-cit commented Jan 6, 2026

Uh oh!

roaks3 commented Jan 6, 2026

Uh oh!

victorsantos-cit commented Jan 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

victorsantos-cit commented Jan 17, 2026 via email

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants