-
Notifications
You must be signed in to change notification settings - Fork 4
feat: deprecate integration_id in favor of deployment_id #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -18,9 +18,9 @@ class GooeyEmbedFactory { | |||||||||||||||||||||||
| `Target not found: ${config.target}. Please provide a valid "target" selector in the config object.`, | ||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
| if (!config.integration_id) { | ||||||||||||||||||||||||
| if (!config.integration_id && !config.deployment_id) { | ||||||||||||||||||||||||
| throw new Error( | ||||||||||||||||||||||||
| `Integration ID is required. Please provide an "integration_id" in the config object.`, | ||||||||||||||||||||||||
| `Deployment ID is required. Please provide an "deployment_id" in the config object.`, | ||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
|
Comment on lines
+21
to
25
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix article in error message. The validation logic correctly maintains backward compatibility by accepting either Apply this diff: - `Deployment ID is required. Please provide an "deployment_id" in the config object.`,
+ `Deployment ID is required. Please provide a "deployment_id" in the config object.`,📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove duplicate
secretsconfiguration.The
secretsconfiguration block appears twice in the example (lines 45-47 and again at lines 65-67). This duplication could confuse users.Apply this diff to remove the duplicate:
branding: { name: "Farmer.CHAT", byLine: "By Digital Green", description: "An AI Assistant designed to help farmer extension agents in India.", conversationStarters: [ "When should I plant chili?", "How can I get rid of black ants on my coffee?", "What is the best time to grow pepper in India?", ], fabLabel: "Help", photoUrl: "https://digitalgreen.org/wp-content/themes/digital-green/images/favicons/apple-touch-icon.png", websiteUrl: "https://digitalgreen.org/", showPoweredByGooey: true, color: { primary: "purple", "secondary": "blue" }, }, - secrets: { - GOOGLE_MAPS_API_KEY: "your-google-maps-api-key-here", - }, payload: { user_id: "123", variables: { product_id: "sample_id", product_name: "sample_name", }, },Also applies to: 65-67
🤖 Prompt for AI Agents