Expose the percentage-function to the Python-bindings by a typemap#2091
Open
rotdrop wants to merge 2 commits intoGnucash:stablefrom
Open
Expose the percentage-function to the Python-bindings by a typemap#2091rotdrop wants to merge 2 commits intoGnucash:stablefrom
rotdrop wants to merge 2 commits intoGnucash:stablefrom
Conversation
The idea is to be able to use the percentage function with a python function callback. Maybe a little bit hacky as SWIG was not designed for these kind of things (i.e. callbacks from the target language back to Python are difficult to achieve with SWIG). Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
jralls
requested changes
May 27, 2025
Member
jralls
left a comment
jralls
left a comment
There was a problem hiding this comment.
Very clever.
Needs a test to go with it.
Author
The credits go actually to https://gist.github.com/sterin/32b5c7c42a177dacf455 Test would also need to be written for my other PR #2090, I'll try to have a look at it ... |
rotdrop
force-pushed
the
feature/expose-percentage-callback-to-python
branch
from
eecabdc to
e7e3b55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to be able to use the percentage function with a python function callback. Maybe a little bit hacky as SWIG was not designed for these kind of things (i.e. callbacks from the target language back to Python are difficult to achieve with SWIG).
Usage:
Complete "save-as" script is here https://github.com/rotdrop/gnucash-python/blob/main/src/save-as.py