Skip to content

(deps): Bump Cake.Frosting from 6.0.0 to 6.1.0 #4835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Mar 13, 2026
Merged

(deps): Bump Cake.Frosting from 6.0.0 to 6.1.0 #4835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10e51e7
(deps): Bump Cake.Frosting from 6.0.0 to 6.1.0
dependabot[bot] Mar 13, 2026
9c1bd70
build(msbuild): Remove MSBuildToolVersion workaround
arturcic Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<PackageVersion Include="Cake.Compression" Version="0.4.0" />
<PackageVersion Include="Cake.Codecov" Version="6.0.0" />
<PackageVersion Include="Cake.Coverlet" Version="6.0.1" />
<PackageVersion Include="Cake.Frosting" Version="6.0.0" />
<PackageVersion Include="Cake.Frosting" Version="6.1.0" />
<PackageVersion Include="Cake.Frosting.Git" Version="5.0.1" />
<PackageVersion Include="Cake.Http" Version="5.1.0" />
<PackageVersion Include="Cake.Incubator" Version="10.0.0" />
Expand Down
33 changes: 18 additions & 15 deletions build/artifacts/Tasks/ArtifactsMsBuildFullTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ public override void Run(BuildContext context)

var nugetSource = context.MakeAbsolute(Paths.Nuget).FullPath;

const int toolVersionValue = 11; // Workaround for now. It should be removed when https://github.com/cake-build/cake/issues/4658 is merged
var isMsBuildToolVersionValid = Enum.IsDefined(typeof(MSBuildToolVersion), toolVersionValue);

context.Information("\nTesting msbuild task with dotnet build\n");
foreach (var netVersion in Constants.DotnetVersions)
{
Expand All @@ -46,25 +43,31 @@ public override void Run(BuildContext context)
var exe = Paths.Integration.Combine("build").Combine(framework).CombineWithFilePath("app.dll");
context.ValidateOutput("dotnet", exe.FullPath, fullSemVer);

if (!isMsBuildToolVersionValid) continue;
if (!Enum.IsDefined(MSBuildToolVersion.VS2026)) continue;

const MSBuildToolVersion toolVersion = (MSBuildToolVersion)toolVersionValue;
context.Information("\nTesting msbuild task with msbuild (for full framework)\n");

var msBuildSettings = new MSBuildSettings
try
{
Verbosity = Verbosity.Minimal,
ToolVersion = toolVersion,
Restore = true
};
var msBuildSettings = new MSBuildSettings
{
Verbosity = Verbosity.Minimal,
ToolVersion = MSBuildToolVersion.VS2026,
Restore = true
};

msBuildSettings.WithProperty("GitVersionMsBuildVersion", version);
msBuildSettings.WithProperty("RestoreSource", nugetSource);
msBuildSettings.WithProperty("GitVersionMsBuildVersion", version);
msBuildSettings.WithProperty("RestoreSource", nugetSource);

context.MSBuild(projPath.FullPath, msBuildSettings);
context.MSBuild(projPath.FullPath, msBuildSettings);

var fullExe = Paths.Integration.Combine("build").CombineWithFilePath("app.exe");
context.ValidateOutput(fullExe.FullPath, null, fullSemVer);
var fullExe = Paths.Integration.Combine("build").CombineWithFilePath("app.exe");
context.ValidateOutput(fullExe.FullPath, null, fullSemVer);
}
catch (Exception e)
{
context.Error(e.Message);
}
Comment on lines +67 to +70
}
}
}
Loading