-
Notifications
You must be signed in to change notification settings - Fork 309
Make Poll Results Dialog Shows All Votes with Pagination Support #6043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,802
−298
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
4034b0b
Introduce Add PollResultsViewController to manage the state and logic…
andremion 3989fd7
Extract a reusable ViewModelStore composable
andremion 54ca195
Refactor PollViewResultDialog to use ViewModel
andremion 7107206
Fix PollViewResultDialog that was cutting the last option items. Usin…
andremion d7d2250
Refactor PollResultsViewState
andremion 6d2c40e
Handle poll results loading error
andremion cfec094
Refactor PollResultsViewState
andremion 5328bad
Refactor: Move Sort poll options by vote count and winner calculation…
andremion 0b5a31b
Refactor: Removes unused error previews and simplifies poll sorting l…
andremion dae1d97
Add XML `PollResultsViewModel`
andremion d2b4f28
Refactor PollResultsDialogFragment to use ViewModel
andremion cceeeb1
Refactor PollResultsDialogFragment creation
andremion b9bb3e7
apiDump
andremion 6011107
Fix poll answer avatar borders
andremion db8ee58
Refactor poll results screen
andremion 352a01b
Use Crossfade in poll dialogs
andremion 9c6c0cc
Update paparazzi tests
andremion 25db00d
Add poll option results ViewModel
andremion ae4dba2
Initial poll option results XML UI
andremion f5d612b
Align the loading more UI
andremion 9cd7396
Update PollResultsViewControllerTest
andremion 490d665
Add PollOptionResultsViewControllerTest
andremion b33cc12
Rename to PollOptionVotes
andremion 5c7899b
Make PollOptionVotesViewModel internal
andremion 3a2fd98
Fix lint
andremion 87de408
Fix poll memory leak
andremion b3da083
Rename to PollOptionVotes
andremion 3c16d64
Fix poll vote dialog crash
andremion 660c3e4
Fix NPE in poll dialogs
andremion 04efee7
Fix test case name
andremion 01687f5
Fix recycled-view corruption when vote.user is null.
andremion a52a788
Refactor PollVoteItem composable
andremion 4d5060d
Remove poll results events
andremion d21ec5f
Fix poll votes list layout
andremion c5ceba2
apiDump
andremion 5ed4650
Extract applyEdgeToEdgePadding extension
andremion 6a4bea0
Fix edge-to-edge in poll dialogs
andremion 29036a5
CHANGELOG
andremion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.