Merged
Conversation
During the build process, the strings in i18n.tpl need to be transformed from UTF-8 into Shift-JIS. However, it was done naively by encoding the file contents itself into Shift-JIS. This caused an issue where if a Shift-JIS sequence generated a `\` (0x5c) character, it would leave that character in the string, leading to unwanted escape sequences (raised by the compiler as warnings) and corrupt that string. The script in this commit only tries to encode the character within the quotation delimiters, and outputting a series of escaped hex characters and also handles special cases such as \r and \n.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See GensokyoClub/th08#22.