Fix function signatures for GameErrorContext methods#377
Open
KSSBrawl wants to merge 2 commits intoGensokyoClub:masterfrom
Open
Fix function signatures for GameErrorContext methods#377KSSBrawl wants to merge 2 commits intoGensokyoClub:masterfrom
KSSBrawl wants to merge 2 commits intoGensokyoClub:masterfrom
Conversation
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
GameErrorContext::LogandGameErrorContext::Fatalare variadic functions, even if they are__thiscall(which they probably were), thethispointer gets shoved onto the stack regardless. As such, there's no reason to make them static aside from needlessly making invoking them twice as verbose.