Changes to to the Build Environment to accommodate ESA needs#1180
Open
Woolly-at-EBI wants to merge 5 commits intomainfrom
Open
Changes to to the Build Environment to accommodate ESA needs#1180Woolly-at-EBI wants to merge 5 commits intomainfrom
Woolly-at-EBI wants to merge 5 commits intomainfrom
Conversation
added value SurfMaterialEnum value as requested by ESA
added values to IndoorSpaceEnum value as requested by ESA
Desc: added values to IndoorSpaceEnum value as requested by ESA
added values to room_type string_serialization was requested by ESA
Some changes request by European Space Agency(ESA) slot_usage air temperature: mandatory->false recommended→true carbon dioxide: mandatory->false recommended→true organism count: mandatory->false recommended→true Added to annotation use cases: European Space Agency(ESA) cleanrooms
Woolly-at-EBI
requested review from
jfy133,
lschriml,
mslarae13,
only1chunts and
turbomam
Contributor
LinkML Linting ResultsSummary
Problems per Schema/home/runner/work/mixs/mixs/src/mixs/schema/mixs.yamlErrors
|
mslarae13
requested changes
Mar 27, 2026
Comment on lines
+16829
to
16832
| - | ||
| - room_vol | ||
| - room_window_count | ||
| - room_connected |
Collaborator
There was a problem hiding this comment.
Suggested change
| - | |
| - room_vol | |
| - room_window_count | |
| - room_connected | |
| - room_vol | |
| - room_window_count | |
| - room_connected |
I think that empty - shouldn't be there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are changes to the Build Environment to accommodate European Space Agency(ESA) needs
ENUM Changes
Serialisation Changes
-Update mixs.yaml for room_type string_serialization with values
Proposed changes to the BuiltEnvironment: - > slot_usage