Figure.ternary: Support Frame's xaxis/yaxis/zaxis attributes to set axis settings for a/b/c axes#4517
Figure.ternary: Support Frame's xaxis/yaxis/zaxis attributes to set axis settings for a/b/c axes#4517
Conversation
|
xref: #4505 (comment) |
|
Actually I would split this into two PRs, one for the code changes for the ternary frame itself and one for updating the tests. |
Actually we have to update the tests in this PR to ensure the code changes are correct. |
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
|
Still need to generate the baseline images and put them to dagshug, following the instructions at https://www.pygmt.org/dev/contributing.html#using-data-version-control-dvc-to-manage-test-images. Let me know if you'd like to do it or need help. |
ok, I can do it. |
|
@seisman |
|
You need to create an account on DagsHub, and then I can add you as a collaborator |
I have logged in using github. |
|
Hmmm. I can't find you https://dagshub.com/Chuan1937 |
I changed to https://dagshub.com/Chuan1937 |
|
Ok. DOne |
Co-authored-by: Dongdong Tian <[email protected]>

Add ternary frame
Update the test
pygmt/tests/test_ternary.pyto use the new implemented Frame and Axis parameter classes.Fixes partly #4494