-
Notifications
You must be signed in to change notification settings - Fork 235
DOC: Improve release checklist #4348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| - [ ] Reserve a DOI on [Zenodo](https://zenodo.org) by clicking on "New Version" | ||
| - [ ] Finish up the "Changelog entry for v0.x.x" Pull Request (Use the previous changelog PR as a reference) | ||
| - [ ] Run `make codespell` to check common misspellings. If there are any, either fix them or add them to `ignore-words-list` in `pyproject.toml` | ||
| - [ ] Check for broken links (e.g., [External Resources](https://www.pygmt.org/dev/external_resources.html)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we missed the broken links because the "Check Links" workflow failed recently (https://github.com/GenericMappingTools/pygmt/actions/runs/20895342763). Related to lycheeverse/lychee#1934
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please move this item to line ~30, and change it to something like:
- [ ] Check for broken links in the [Check Links](https://github.com/GenericMappingTools/pygmt/actions/workflows/check-links.yml)
| - [ ] All tests pass in the ["GMT Legacy Tests" workflow](https://github.com/GenericMappingTools/pygmt/actions/workflows/ci_tests_legacy.yaml) | ||
| - [ ] All tests pass in the ["GMT Dev Tests" workflow](https://github.com/GenericMappingTools/pygmt/actions/workflows/ci_tests_dev.yaml) | ||
| - [ ] All tests pass in the ["Doctests" workflow](https://github.com/GenericMappingTools/pygmt/actions/workflows/ci_doctests.yaml) | ||
| - [ ] Check for broken links in the [Check Links](https://github.com/GenericMappingTools/pygmt/actions/workflows/check-links.yml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - [ ] Check for broken links in the [Check Links](https://github.com/GenericMappingTools/pygmt/actions/workflows/check-links.yml) | |
| - [ ] Check for broken links in the ["Check Links" workflow](https://github.com/GenericMappingTools/pygmt/actions/workflows/check-links.yml) |
Description of proposed changes
Two small improvements of the release checklist.
Guidelines
Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code