MultiTextureStyle rework : fixed error when maxTextures > 2, up to 16…#1144
Open
MatseFR wants to merge 4 commits into
Open
MultiTextureStyle rework : fixed error when maxTextures > 2, up to 16…#1144MatseFR wants to merge 4 commits into
MatseFR wants to merge 4 commits into
Conversation
… textures + optimizations
Contributor
|
If it's up to 16 textures shouldn't |
Contributor
Author
|
@Fancy2209 it is, if the profile is not baseline, otherwise it's limited to 5 because of AGAL 1 (no ifs) |
…, when the profile is known MAX_NUM_TEXTURES applies
Contributor
Author
|
all issues have been fixed, except the one that current MultiTextureStyle has too ( #1145 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… textures + optimizations
There is currently an issue with
MultiTextureStyle: whenMultiTextureStyle.maxTexturesis set to3or more the following error is thrown as soon as the program is activated :[Fault] exception, information=Error: Error #3647: AGAL validation failed: Temporary register read without being written to for source operand 1 at token 13 of fragment program.This version has been tested with 2000 movie clips with 1 to 16 different textures : I'm not sure I got the
programVariantNameright though ?