-
Notifications
You must be signed in to change notification settings - Fork 5
Support most recent unxt (#484) #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support most recent unxt (#484) #487
Conversation
ebebba9 to
b62e615
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the unxt dependency from version 1.7.3 to 1.10.3, bringing in newer features and improved type annotations. The changes are mechanical API compatibility updates required by the new version of unxt.
Changes:
- Upgraded
unxtdependency from v1.7.3 to v1.10.3 in bothpyproject.tomlanduv.lock - Updated wadler-lindig formatting API calls to use new
short_arrays="compact"syntax instead ofcompact_arrays=True - Changed import path from
unxt._src.dimensions.coretounxt._src.dimensions - Updated type annotations from
AstropyUnitstou.AbstractUnitfor better type safety - Removed unnecessary
type: ignore[no-untyped-call]comments (improved type stubs in new unxt version) - Updated docstring example to reflect new Array repr format with
weak_typeattribute
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated unxt version requirement from >=1.7.3 to >=1.10.3 |
| uv.lock | Updated unxt package from 1.7.3 to 1.10.3 and added new transitive dependency unxt-api v1.10.1 |
| src/coordinax/_src/vectors/converters.py | Reformatted function signature (no functional change) |
| src/coordinax/_src/vectors/collection/utils.py | Updated import path from unxt._src.dimensions.core to unxt._src.dimensions |
| src/coordinax/_src/vectors/base/vector.py | Changed wadler-lindig parameter from compact_arrays=True to short_arrays="compact" |
| src/coordinax/_src/vectors/base/base.py | Changed wadler-lindig parameter from compact_arrays=True to short_arrays="compact" |
| src/coordinax/_src/operators/galilean/rotation.py | Removed unnecessary type: ignore[no-untyped-call] comment |
| src/coordinax/_src/operators/base.py | Changed wadler-lindig parameters from compact_arrays to short_arrays="compact" |
| src/coordinax/_src/distances/measures.py | Updated type annotations from AstropyUnits to u.AbstractUnit and updated docstring to reflect new Array repr format |
| src/coordinax/_coordinax_space_frames/frame_transforms.py | Removed unnecessary type: ignore[no-untyped-call] comment |
b1d6b0f to
d45fe48
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## versions/v0.23.x #487 +/- ##
====================================================
- Coverage 98.78% 98.73% -0.05%
====================================================
Files 152 152
Lines 4361 4360 -1
====================================================
- Hits 4308 4305 -3
- Misses 53 55 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
af5abe0 to
adfdc7b
Compare
* ⬆️ dep-bump: unxt v1.10.3+ * 🚨 fix-lint: mypy * 🚨 fix-lint: mypy Signed-off-by: nstarman <[email protected]> (cherry picked from commit 8ab58a3) Signed-off-by: nstarman <[email protected]>
adfdc7b to
1ceba54
Compare
713db9c
into
GalacticDynamics:versions/v0.23.x
(cherry picked from commit 8ab58a3)