Skip to content

Conversation

@nstarman
Copy link
Contributor

  • ⬆️ dep-bump: unxt v1.10.3+
  • 🚨 fix-lint: mypy
  • 🚨 fix-lint: mypy

(cherry picked from commit 8ab58a3)

@github-actions github-actions bot added the 🔧 Add / update configuration Add or update configuration files. label Jan 31, 2026
@nstarman nstarman force-pushed the versions/v0.23.x-fix branch 2 times, most recently from ebebba9 to b62e615 Compare January 31, 2026 18:54
@nstarman nstarman added this to the v0.23.x milestone Jan 31, 2026
@nstarman nstarman marked this pull request as ready for review January 31, 2026 18:56
Copilot AI review requested due to automatic review settings January 31, 2026 18:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the unxt dependency from version 1.7.3 to 1.10.3, bringing in newer features and improved type annotations. The changes are mechanical API compatibility updates required by the new version of unxt.

Changes:

  • Upgraded unxt dependency from v1.7.3 to v1.10.3 in both pyproject.toml and uv.lock
  • Updated wadler-lindig formatting API calls to use new short_arrays="compact" syntax instead of compact_arrays=True
  • Changed import path from unxt._src.dimensions.core to unxt._src.dimensions
  • Updated type annotations from AstropyUnits to u.AbstractUnit for better type safety
  • Removed unnecessary type: ignore[no-untyped-call] comments (improved type stubs in new unxt version)
  • Updated docstring example to reflect new Array repr format with weak_type attribute

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pyproject.toml Updated unxt version requirement from >=1.7.3 to >=1.10.3
uv.lock Updated unxt package from 1.7.3 to 1.10.3 and added new transitive dependency unxt-api v1.10.1
src/coordinax/_src/vectors/converters.py Reformatted function signature (no functional change)
src/coordinax/_src/vectors/collection/utils.py Updated import path from unxt._src.dimensions.core to unxt._src.dimensions
src/coordinax/_src/vectors/base/vector.py Changed wadler-lindig parameter from compact_arrays=True to short_arrays="compact"
src/coordinax/_src/vectors/base/base.py Changed wadler-lindig parameter from compact_arrays=True to short_arrays="compact"
src/coordinax/_src/operators/galilean/rotation.py Removed unnecessary type: ignore[no-untyped-call] comment
src/coordinax/_src/operators/base.py Changed wadler-lindig parameters from compact_arrays to short_arrays="compact"
src/coordinax/_src/distances/measures.py Updated type annotations from AstropyUnits to u.AbstractUnit and updated docstring to reflect new Array repr format
src/coordinax/_coordinax_space_frames/frame_transforms.py Removed unnecessary type: ignore[no-untyped-call] comment

@nstarman nstarman force-pushed the versions/v0.23.x-fix branch 2 times, most recently from b1d6b0f to d45fe48 Compare January 31, 2026 19:02
@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.73%. Comparing base (7316ccd) to head (1ceba54).
⚠️ Report is 1 commits behind head on versions/v0.23.x.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           versions/v0.23.x     #487      +/-   ##
====================================================
- Coverage             98.78%   98.73%   -0.05%     
====================================================
  Files                   152      152              
  Lines                  4361     4360       -1     
====================================================
- Hits                   4308     4305       -3     
- Misses                   53       55       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nstarman nstarman force-pushed the versions/v0.23.x-fix branch 2 times, most recently from af5abe0 to adfdc7b Compare January 31, 2026 19:23
* ⬆️ dep-bump: unxt v1.10.3+
* 🚨 fix-lint: mypy
* 🚨 fix-lint: mypy

Signed-off-by: nstarman <[email protected]>
(cherry picked from commit 8ab58a3)
Signed-off-by: nstarman <[email protected]>
@nstarman nstarman force-pushed the versions/v0.23.x-fix branch from adfdc7b to 1ceba54 Compare January 31, 2026 19:24
@nstarman nstarman merged commit 713db9c into GalacticDynamics:versions/v0.23.x Jan 31, 2026
18 of 19 checks passed
@nstarman nstarman deleted the versions/v0.23.x-fix branch January 31, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔧 Add / update configuration Add or update configuration files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant