docs: changed read_config docstring & made use off it - #379
Open
TKleinwort wants to merge 2 commits into
Open
Conversation
…provider_to_settings
Collaborator
|
You'll need to run |
merydian
requested changes
Aug 3, 2026
merydian
left a comment
merydian
left a comment
Collaborator
There was a problem hiding this comment.
All in all a very solid approach!
Collaborator
There was a problem hiding this comment.
Is this file here intentionally?
| def __init__(self, parent=None): | ||
| super().__init__(parent) | ||
|
|
||
| self.setIcon(QMessageBox.Warning) |
Collaborator
There was a problem hiding this comment.
This isn't compatible with Qt6, try to use QGIS4 for development to check for these errors.
| QgsApplication.processingRegistry().addProvider(self.provider) | ||
| self.dialog.initGui() | ||
| # starts deprecated url dialog after QGIS Main-Window opened | ||
| iface.initializationCompleted.connect(self.check_provider_url) |
Collaborator
There was a problem hiding this comment.
This doesn't trigger somehow, what about just calling the function here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_config is now imported and called in add_default_provider_to_settings (inside of ORStoolsPlugin.py) to avoid redundant text.