Skip to content

feat(roads-thematic-accuracy): add thematic accuracy indicator for road attributes #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matthiasschaub merged 55 commits into from
Jan 21, 2026
Merged

feat(roads-thematic-accuracy): add thematic accuracy indicator for road attributes #980

matthiasschaub merged 55 commits into from
Jan 21, 2026

Conversation

@Gigaszi
Copy link
Collaborator

@Gigaszi Gigaszi commented Jan 12, 2026

Please add the type of change as label. If your PR is not ready for review and merge, please add 🚧 to the PR title.

Description

Please add a clear and concise description of what your PR solves.

Corresponding issue

Closes #

New or changed dependencies

Checklist

  • I have ensured my branch is mergeable with main (e.g. through git rebase main if necessary)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have added new Hurl regression tests and checked all existing tests
  • I have updated the CHANGELOG.md

Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using ~...~) and remove their checkboxes.

Gigaszi and others added 30 commits January 6, 2026 10:50
@Gigaszi
feat: add basic structure for RoadAccuracy indicator
32c52bf
@Gigaszi
WIP: add basic functionality and first plot draft
a290044
@Gigaszi
feat: add road-accuracy to topic roads
c82ffc6
@Gigaszi
WIP: road accuracy is working in the dashboard with name attribute
42647e8
@Gigaszi
feat: rename indicator to RoadsThematicAccuracy
fa9405f
@Gigaszi
WIP: add api endpoint and sql queries
b39ae25
@Gigaszi
WIP: add sql queries
1e671ff
@Gigaszi
WIP: use attributes to selected queries
7217ed0
@matthiasschaub
refactor(roads-thematic-accuracy): use literal instead of enum
ab37185 
add tests for request models, api and main regarding
roads-thematic-accuracy indicator
@matthiasschaub
tests: refactor tests into parametrized tests
da2c8cd
@Gigaszi
fix: do not create figure for allignment when there are no columns wi…
655cc34 
…th both attributes
@Gigaszi
feat: add sql queries for oneway and all attributes
e717766
@matthiasschaub
tests: add first test case for roads_thematic_accuracy indicator
f1f7991
@Gigaszi
fix: use right table name in oneway and all attributes sql queries
a976a8f
@Gigaszi
WIP: index response by name and use lowercse column names
572ad01
@matthiasschaub
build: add pytest-approval as dev dependency
4e908b4
@matthiasschaub
tests(road-thematic-accuracy): implement approval testing for preprocess
eafcad0
@matthiasschaub
tests: re-approve land-cover-thematic-accuracy figure due to date change
42e5d4a 
2025 -> 2026
@matthiasschaub
tests(road-thematic-accuracy): add approval tests for calculate method
0c426d1
@matthiasschaub
tests(roads-thematic-accuracy): add approval tests for create figure
2026fd2
@matthiasschaub
tests: fix pytest-approval directory name
e94871e
@matthiasschaub
tests(roads-thematic-accuracy): make main.py tests work
507b5e3
@Gigaszi
feat: add result description
6bc9547
@Gigaszi
fix: correct query for all attributes
d38ffc7
@Gigaszi
feat: remove size restriction from RoadsThematicAccuracyIndicator
5490c34
@Gigaszi
feat: query for length of not matched dlm roads
85dd6d6
@Gigaszi
feat: use length instead of count in queries
d85a266
@Gigaszi
feat: add timestamps not originated from data
194f521
@Gigaszi
feat: add timestamps to plot
ca5a7bc
@Gigaszi
refactor: move sql files in separate directory
a6a0837
@matthiasschaub matthiasschaub changed the title WIP: RoadsThematicAccurracy indicator feat(roads-thematic-accuracy): add thematic accuracy indicator for road attributes Jan 19, 2026
matthiasschaub and others added 20 commits January 19, 2026 11:28
@matthiasschaub
tests: provide different bpolys as fixture to road-accurracy-indicator
3901999 
re-approve approval tests and re-create asyncpg recorder cassette
@matthiasschaub
build: upgrade pytest-approval
c02ca6e
@Gigaszi
docs(road-thematic-accuracy): add information to indicator calculation
afb5fdd
@Gigaszi
refactor: mention in result description if there are not attributes i…
fa6c78e 
…n both datasets

avoid ZeroDivisionError
@Gigaszi
tests: add test for no shared attribute
e219f80
@Gigaszi
fix: check for no data in response
3cbae77
@Gigaszi
feat: limit axes to zero
901d04b
@Gigaszi
i18n: add i18n to missing strings
c8987f4
@Gigaszi
feat: add description of RoadThematicAccuracy
342e96c
@Gigaszi
i18n: add translations to german
d660435
@matthiasschaub
tests: use heidelberg as feature for road-thematic-accurracy indicator
8ded16d
@matthiasschaub
refactor: remove validator from child because its covered by parent
9a30e33
@matthiasschaub
refactor: introduce indicator key property for request models
a9662f6 
this enables proper inheritance of validator
@matthiasschaub
tests: add invalid topic and attribute test cases for road-accuracy
63ab1d0 
indicator
@matthiasschaub
tests: remove mocks which are not needed
56510c4
@matthiasschaub
style: remove comma and run ruff
255a7c5
@matthiasschaub
refactor: make code easier to read
6255e6d 
by avoiding doing much in one statement and pulling out if statements
@matthiasschaub
refactor(road-accurracy-indicator): make fig descriptions more detailed
8ef7f9b
@matthiasschaub
try to fix vcr problems
139c723
@matthiasschaub
add changelog
ab6dd00
@matthiasschaub matthiasschaub merged commit dfc9b12 into main Jan 21, 2026
1 of 2 checks passed
@matthiasschaub matthiasschaub deleted the road-accurracy-indicator branch January 21, 2026 10:45
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 21, 2026

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.2% Coverage on New Code
3.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gigaszi @matthiasschaub