checking if content is blank in is_multimodal#333
Closed
Conversation
dosubot
bot
added
the
size:XS
There was a problem hiding this comment.
Pull request overview
This PR fixes a potential bug in the is_multimodal property by adding a check for blank/None content before attempting to parse it as JSON.
Changes:
- Added
not self.contentcheck in theis_multimodalproperty guard clause to prevent attempting to parse null or empty content
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| def is_multimodal(self) -> bool: | ||
| """Check if content is encoded multimodal data.""" | ||
| if not self.content_is_json_str: | ||
| if not self.content_is_json_str or not self.content: |
There was a problem hiding this comment.
The edge case where content_is_json_str is True but content is None or empty lacks test coverage. Consider adding a test case to verify that is_multimodal correctly returns False when content is blank, even if content_is_json_str is True.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.