Conversation
For more information on rewrite, see README
black linter leftovers
Logging is handled via loguru. Defaults to INFO level, but DEBUG will always appear in log file. game_info.json data is stored in the util.variables as the game_info dictionary. Library discovery is added for Steam in step.load_gameinfo and is stored
Implemented path discovery, download, extract, install. Added scriptextender checksums to game_info.json for validation.
Additonal: Updated TODOs to output a 'not yet implemented' message, Fixed script always thinking the game had an install through Heroic if Heroic was installed, adjust remaining json["key"] calls to use .get("key") for safer access.
Updating for consistency with bash wiki
commas over underscores
Base docker setup
Resolves #933
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in the README 'state of development', we're currently rewriting the entire codebase in Python to allow for better readability and, consequentially, a better contributor experience.
As of the creation of this PR, the development is not finished yet.
We are still working to implement the NXM:// protocol handler (Nexus's 'Mod Manager Download' button), the Steam Redirector, and game-specific workarounds, as well as a few other small niceties.
Further details can be found on the rewrite branch's README and in the rewrite discussion thread.