[BUGFIX] prevent GF hairFall animation on song retry #360
+40
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Animation Reset: Added `playAnimation('danceLeft', true)` to onSongRetry to force a clean transition when restarting.
- Audio Cleanup: Included a `trainSound.stop()` call in the retry sequence to prevent the train whistle from carrying over into the next attempt.
github-actions
bot
added
status: pending triage
Contributor
|
chatgpt ass description |
ComedyLost
reviewed
Feb 5, 2026
| // Force GF to reset to her idle dance immediately. | ||
| if (getGirlfriend() != null) | ||
| { | ||
| getGirlfriend().playAnimation('danceLeft', true); |
Contributor
There was a problem hiding this comment.
Why not use getGirlfriend().dance(true) instead of playing specifically the danceLeft animation
Author
There was a problem hiding this comment.
idk why i didnt think of that. im so used to the old source code i just stuck with that instead
Hundrec
added
type: minor bug
Softcoded GF's dance anims
Applied the same sticky-hair fixes to erect stages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Funkin PR
Linked Issues
Closes #6749 (Girlfriend's hairFall animation plays after restarting in Philly Train stages)
Description
This PR addresses a visual bug where GF's
hairFallanimation would trigger immediately upon restarting the song inPhillyTrain.hxcChanges
trainReset()so hairFall only plays if startedMoving is true.getGirlfriend.dance(true)to onSongRetry to force a clean transition when restarting.trainSound.stop()call in the retry sequence to prevent the train whistle from carrying over into the next attempt.Screenshots/Videos
Original Bug Report
StickyHair_BUG_REPORT.mp4
Bug Fix
StickyHair_BUG_FIX.mp4
Applied these fixes to the erect stages also:
StickyHairErect_BUG_FIX.mp4