feat: refactor check_unique_rules to be more modular#964
Open
varun-doshi wants to merge 1 commit intoFuelLabs:masterfrom
Open
feat: refactor check_unique_rules to be more modular#964varun-doshi wants to merge 1 commit intoFuelLabs:masterfrom
varun-doshi wants to merge 1 commit intoFuelLabs:masterfrom
Conversation
varun-doshi
requested review from
Dentosal,
MitchTurner,
Voxelot and
xgreenx
as code owners
|
Thanks for the contribution! Before we can merge this, we need @varun-doshi to sign the Fuel Labs Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #800
Currently some implementations of
verify_blob_idof are left empty because the code did not fit the name (please correct me if im wrong)...I was wondering if it needs some other name likeverify_dataor somethingPlease correct me if i'm misunderstanding that.