Do not store image in cache if error

[ArnyminerZ]

Closes #2060

Currently, the images loaded from Immich (I guess also Photoprism) are always stored in cache, no matter whether the server responded successfully or not.

This is a simple PR to make sure no errors (or empty images) are stored in cache.

---

I can't find where to suggest updates to the documentation, but this page must be updated to indicate that the asset.view is also required, as explained in the original issue.

Summary by CodeRabbit

Release Notes

• New Features

  • Added interactive route visualization with hover highlights and emoji markers for route start/end points
  • Introduced route information panel displaying start time, end time, distance, duration, and speed
  • Added tracks layer to map with GeoJSON support and visibility toggle in settings
  • Implemented tracks API endpoint with pagination support

• Improvements

  • Enhanced map performance by optimizing marker sizes and distance calculations
  • Improved point creation workflows with synchronous processing and better error handling
  • Added pagination to visits, places, and tracks endpoints with header information
  • Implemented total distance caching for improved performance

• Bug Fixes

  • Resolved route map rendering parity between Map V1 and V2
  • Disabled Rails Pulse on self-hosted instances

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR introduces synchronous point creation APIs for Overland and OwnTracks sources, adds a new Tracks API with GeoJSON serialization, implements route interaction features in MapLibre (hover, selection, info display), and adds comprehensive Prometheus metrics for archive operations. It removes background job enqueueing in favor of synchronous service execution and expands pagination support across multiple endpoints.

Changes

Cohort / File(s)	Summary
Documentation AGENTS.md, CHANGELOG.md, CLAUDE.md	Repository guidelines (project structure, architecture, testing, security), changelog entries for v0.37.3 fixes and v0.37.2 features, and documented unit mismatch in route drawing logic between Map v1 and v2.
Point Creation API Changes app/controllers/api/v1/overland/batches_controller.rb, app/controllers/api/v1/owntracks/points_controller.rb	Replaced asynchronous job enqueueing with synchronous service calls (Overland::PointsCreator, OwnTracks::PointCreator). Added error handling with Sentry integration and standardized error responses.
New Tracks API app/controllers/api/v1/tracks_controller.rb, app/queries/tracks/index_query.rb, app/serializers/tracks/geojson_serializer.rb, config/routes.rb	New Api::V1::TracksController#index with pagination and date-range filtering. Query object for scoped track retrieval and GeoJSON serialization of track data.
Pagination & Data Fetching Enhancements app/controllers/api/v1/places_controller.rb, app/controllers/api/v1/visits_controller.rb, app/controllers/api/v1/points_controller.rb, app/controllers/api/v1/photos_controller.rb	Added optional pagination with headers (X-Current-Page, X-Total-Pages, X-Total-Count); optimized places query using ID-based union; conditional cache validation for photos; error handling in points update.
Point Creation Services (Synchronous) app/services/overland/points_creator.rb, app/services/own_tracks/point_creator.rb, app/services/overland/params.rb	New synchronous creators with batch upsert via Point.upsert_all. Enhanced params parsing with altitude, velocity, tracker_id, ssid, accuracy data. Returns created point records with coordinates.
Archive Metrics Services app/services/metrics/archives/compression_ratio.rb, app/services/metrics/archives/count_mismatch.rb, app/services/metrics/archives/operation.rb, app/services/metrics/archives/points_archived.rb, app/services/metrics/archives/size.rb, app/services/metrics/archives/verification.rb	New Prometheus metric emitters for archive lifecycle: compression ratio, count mismatches, operation status, archived points count, archive size, and verification duration/failures.
Archive Verification & Operations app/services/points/raw_data/archiver.rb, app/services/points/raw_data/verifier.rb, app/services/points/raw_data/clearer.rb, app/services/points/raw_data/restorer.rb, app/services/points/raw_data/chunk_compressor.rb	Enhanced archiver with immediate verification post-archive, count mismatch detection, and metrics reporting. Compressor returns hash with data and count. Clearer and restorer emit operation metrics. Verifier adds timing and check classification.
Cache & Statistics app/services/cache/preheating_job.rb, app/services/cache/invalidate_user_caches.rb, app/services/cache/clean.rb, app/models/user.rb, app/controllers/stats_controller.rb, app/services/stats/calculate_month.rb	New total_distance caching with 1-day expiry. Cache invalidation and cleanup methods. Stats controller refactored to use column selection and combined ordering. Calculate_month reuses point collection for toponym extraction.
Model Enhancements app/models/points/raw_data_archive.rb	Added numeric constraint for point_count, metadata validation for expected/actual counts, and public methods verified? and count_mismatch?.
MapLibre Route Interactions app/javascript/controllers/maps/maplibre/event_handlers.js	New route-aware interactions: hover effects, selection state tracking, start/end emoji markers, route info display. Added methods: handleRouteHover, handleRouteMouseLeave, handleRouteClick, clearRouteSelection, helpers for feature matching and marker creation.
MapLibre Layer & Data Management app/javascript/controllers/maps/maplibre/layer_manager.js, app/javascript/controllers/maps/maplibre/map_data_manager.js, app/javascript/maps_maplibre/layers/routes_layer.js	Added routes-hit interaction layer with hover state. LayerManager now guards against duplicate event handler setup. MapDataManager wires route handlers to layer setup. RoutesLayer enhanced with hover source, hover route updates, and lifecycle overrides.
Route Utilities & Data Processing app/javascript/maps_maplibre/utils/route_segmenter.js, app/javascript/maps_maplibre/services/api_client.js	New RouteSegmenter class for distance calculations, segment splitting, and route feature generation with IDL crossing support. API client adds parallelized pagination with maxConcurrent limit; new methods: fetchVisits, fetchPlaces, fetchTracks with per-page variants and progress reporting.
MapLibre UI & Settings app/javascript/controllers/maps/maplibre_controller.js, app/javascript/maps/marker_factory.js, app/views/map/maplibre/_settings_panel.html.erb	Added route info UI targets and showRouteInfo method. Route info template for display. Settings panel re-enables and updates Tracks control description, adds route info UI template. Marker default size reduced from 8 to 4.
Track Segmentation app/services/tracks/segmentation.rb, app/services/tracks/parallel_generator.rb	Removed distance-based segmentation logic; now time-only via time_gap_exceeded?. Added metadata field distance_threshold_behavior: 'ignored_for_frontend_parity'.
Background Job Removals app/jobs/overland/batch_creating_job.rb, app/jobs/owntracks/point_creating_job.rb, app/jobs/users/mailer_sending_job.rb	Deleted batch and point creating jobs (replaced by synchronous services). Updated mailer job to use guard clause instead of skip_reason helper.
Infrastructure & Configuration docker/web-entrypoint.sh, config/initializers/rails_pulse.rb, lib/tasks/demo.rake	Docker entrypoint adds optional Prometheus exporter startup. Rails Pulse now disabled in self-hosted environments. Demo rake task adds track creation (20 tracks) before family creation with haversine distance helper.
Distance Calculation app/controllers/map/leaflet_controller.rb	Replaced Ruby-based distance aggregation with PostGIS SQL window function (LAG) for pairwise distance calculation. Added import_id filter path.
Visits Management app/services/visits/find_in_time.rb, app/services/visits/find_within_bounding_box.rb	Broadened eager loading to include both :place and :area associations.
Debug Logging Cleanup app/javascript/controllers/maps/maplibre/area_selection_manager.js, app/javascript/controllers/maps/maplibre/places_manager.js, app/javascript/controllers/maps/maplibre/visits_manager.js, app/javascript/maps_maplibre/layers/base_layer.js	Removed numerous console.log and console.error debug statements across area selection, places, visits, and base layer lifecycle.
E2E Tests - Routes e2e/v2/map/interactions.spec.js	Comprehensive new test suite covering route hover, selection, info display, marker presence/removal, cursor changes, multiple route interactions, and deselection. Tests visual feedback and modal content.
E2E Tests - Tracks e2e/v2/map/layers/tracks.spec.js	New test suite validating Tracks layer UI toggling, visibility, data integrity (LineString geometry, red color), metadata properties, styling, date navigation persistence.
E2E Tests - UI Interaction Updates e2e/v2/map/layers/family.spec.js, e2e/v2/map/layers/points.spec.js, e2e/v2/map/search.spec.js	Updated family members test to data-driven assertions. Points tests replaced manual layer visibility checks with UI-driven checkbox toggling. Search tests wait for modal attachment before assertion.
E2E Test Helpers e2e/v2/helpers/setup.js	Added utility functions: waitForSettingsPanel, waitForActiveTab, openSettingsTab, waitForLayer, waitForLayerVisibility for settings/layer interactions.
RSpec Tests - Point Creation spec/requests/api/v1/overland/batches_spec.rb, spec/requests/api/v1/owntracks/points_spec.rb, spec/services/overland/points_creator_spec.rb, spec/services/own_tracks/point_creator_spec.rb	Updated API specs to assert immediate point creation instead of job enqueueing. Added service-level specs validating idempotency, invalid data handling, and coordinate extraction.
RSpec Tests - Tracks spec/requests/api/v1/tracks_spec.rb, spec/serializers/tracks/geojson_serializer_spec.rb, spec/services/tracks/index_query_spec.rb	New specs for Tracks API (GeoJSON response, pagination, date range filtering), serializer structure validation, and query object behavior.
RSpec Tests - Archive Operations spec/services/points/raw_data/archiver_spec.rb, spec/services/points/raw_data/chunk_compressor_spec.rb, spec/services/points/raw_data/verifier_spec.rb	Enhanced archiver tests with count validation and immediate verification. Compressor tests updated for hash return value.
RSpec Tests - Metrics spec/services/metrics/archives/*.rb	New test files for all Prometheus metric emitters (compression_ratio, count_mismatch, operation, points_archived, size, verification) validating metric payload, labels, and disabled-exporter behavior.
RSpec Tests - Segmentation spec/services/tracks/segmentation_spec.rb, spec/services/tracks/parallel_generator_spec.rb	New segmentation tests for time-gap-only splitting logic. Parallel generator tests validate distance_threshold_behavior metadata presence.
RSpec Tests - Removed spec/jobs/overland/batch_creating_job_spec.rb, spec/jobs/owntracks/point_creating_job_spec.rb	Deleted job specs (jobs removed in favor of synchronous services).
RSpec Tests - Updated spec/requests/api/v1/users_spec.rb	Updated user serializer tests to expect additional globe_projection setting key.
Test Fixtures spec/factories/points_raw_data_archives.rb	Updated metadata factory to dynamically include expected_count and actual_count derived from point_count.

Sequence Diagrams

sequenceDiagram
    participant Client as External Client
    participant Controller as Overland/OwnTracks<br/>Controller
    participant Service as PointsCreator<br/>Service
    participant DB as Database<br/>(Point.upsert_all)
    
    Client->>Controller: POST batch/points with location data
    Controller->>Service: new(params, user_id).call
    Service->>Service: Parse & validate params<br/>(via Params class)
    Service->>Service: Filter incomplete locations
    Service->>Service: Merge user_id into payload
    Service->>DB: upsert_all with RETURNING<br/>(chunks of 1000)
    DB-->>Service: Created point records<br/>(id, timestamp, lon, lat)
    Service-->>Controller: Array of created points
    Controller-->>Client: JSON response<br/>(201 or error)

Loading

sequenceDiagram
    participant Client as API Client
    participant Controller as TracksController
    participant Query as Tracks::IndexQuery
    participant Serializer as Tracks::GeojsonSerializer
    participant DB as Database
    
    Client->>Controller: GET /api/v1/tracks?page=1&per_page=100
    Controller->>Query: new(user, params).call
    Query->>DB: Fetch user's tracks<br/>(ordered, date-filtered, paginated)
    DB-->>Query: Track records
    Query-->>Controller: Paginated relation +<br/>pagination_headers
    Controller->>Serializer: new(tracks).call
    Serializer->>Serializer: Convert each track to<br/>GeoJSON Feature
    Serializer-->>Controller: FeatureCollection
    Controller-->>Client: JSON + pagination headers<br/>(X-Current-Page, X-Total-Pages, X-Total-Count)

Loading

sequenceDiagram
    participant User as User<br/>(Map UI)
    participant Handler as EventHandlers
    participant Layer as LayerManager
    participant Source as MapLibre<br/>Sources
    
    User->>Handler: Hover over route
    Handler->>Handler: _getFullRouteFeature(properties)
    Handler->>Source: setData on hover source
    Source-->>Handler: Hover layer updates
    Handler->>Handler: _createRouteMarkers(features)<br/>(emoji markers)
    Handler-->>User: Visual feedback:<br/>highlight + markers
    
    User->>Handler: Click route
    Handler->>Handler: handleRouteClick(e)
    Handler->>Handler: Update selectedRouteFeature<br/>Compute metrics
    Handler->>User: Emit showRouteInfo<br/>(to controller)
    
    User->>Handler: Click outside route
    Handler->>Handler: clearRouteSelection()
    Handler->>Source: Clear hover data<br/>Clear markers
    Handler->>User: Deselect + close panel

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related PRs

• 0.36.3 #2013: Modifies the archive verification and storage subsystem (Points::RawData::Archiver, ChunkCompressor, models, verifier/clearer services, and related tests) with overlapping archive implementation details.
• 0.37.1 #2092: Updates app/services/points/raw_data/verifier.rb with changes to archive verification behavior and error handling for missing points.
• 0.37.2 #2114: Introduces overlapping MapLibre changes (routes/tracks layers, globe projection settings, frontend serializers) and API endpoint modifications for map data.

Poem

🐰 Routes now glow when we hover near,
Tracks sing in red, crisp and clear,
Prometheus watches with metrics bright,
Synchronous points, forever in flight,
From jobs to services, the code runs tight!

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f00460c and aec9df0.

📒 Files selected for processing (87)

• AGENTS.md
• CHANGELOG.md
• CLAUDE.md
• app/controllers/api/v1/overland/batches_controller.rb
• app/controllers/api/v1/owntracks/points_controller.rb
• app/controllers/api/v1/photos_controller.rb
• app/controllers/api/v1/places_controller.rb
• app/controllers/api/v1/points_controller.rb
• app/controllers/api/v1/tracks_controller.rb
• app/controllers/api/v1/visits_controller.rb
• app/controllers/map/leaflet_controller.rb
• app/controllers/stats_controller.rb
• app/javascript/controllers/maps/maplibre/area_selection_manager.js
• app/javascript/controllers/maps/maplibre/data_loader.js
• app/javascript/controllers/maps/maplibre/event_handlers.js
• app/javascript/controllers/maps/maplibre/layer_manager.js
• app/javascript/controllers/maps/maplibre/map_data_manager.js
• app/javascript/controllers/maps/maplibre/places_manager.js
• app/javascript/controllers/maps/maplibre/visits_manager.js
• app/javascript/controllers/maps/maplibre_controller.js
• app/javascript/maps/marker_factory.js
• app/javascript/maps_maplibre/layers/base_layer.js
• app/javascript/maps_maplibre/layers/routes_layer.js
• app/javascript/maps_maplibre/services/api_client.js
• app/javascript/maps_maplibre/utils/route_segmenter.js
• app/javascript/maps_maplibre/utils/settings_manager.js
• app/jobs/cache/preheating_job.rb
• app/jobs/overland/batch_creating_job.rb
• app/jobs/owntracks/point_creating_job.rb
• app/jobs/users/mailer_sending_job.rb
• app/models/points/raw_data_archive.rb
• app/models/user.rb
• app/queries/tracks/index_query.rb
• app/serializers/tracks/geojson_serializer.rb
• app/services/cache/clean.rb
• app/services/cache/invalidate_user_caches.rb
• app/services/metrics/archives/compression_ratio.rb
• app/services/metrics/archives/count_mismatch.rb
• app/services/metrics/archives/operation.rb
• app/services/metrics/archives/points_archived.rb
• app/services/metrics/archives/size.rb
• app/services/metrics/archives/verification.rb
• app/services/overland/params.rb
• app/services/overland/points_creator.rb
• app/services/own_tracks/point_creator.rb
• app/services/points/raw_data/archiver.rb
• app/services/points/raw_data/chunk_compressor.rb
• app/services/points/raw_data/clearer.rb
• app/services/points/raw_data/restorer.rb
• app/services/points/raw_data/verifier.rb
• app/services/stats/calculate_month.rb
• app/services/tracks/parallel_generator.rb
• app/services/tracks/segmentation.rb
• app/services/visits/find_in_time.rb
• app/services/visits/find_within_bounding_box.rb
• app/views/map/maplibre/_settings_panel.html.erb
• config/initializers/rails_pulse.rb
• config/routes.rb
• docker/web-entrypoint.sh
• e2e/v2/helpers/setup.js
• e2e/v2/map/interactions.spec.js
• e2e/v2/map/layers/family.spec.js
• e2e/v2/map/layers/points.spec.js
• e2e/v2/map/layers/tracks.spec.js
• e2e/v2/map/search.spec.js
• lib/tasks/demo.rake
• spec/factories/points_raw_data_archives.rb
• spec/jobs/overland/batch_creating_job_spec.rb
• spec/jobs/owntracks/point_creating_job_spec.rb
• spec/requests/api/v1/overland/batches_spec.rb
• spec/requests/api/v1/owntracks/points_spec.rb
• spec/requests/api/v1/tracks_spec.rb
• spec/requests/api/v1/users_spec.rb
• spec/serializers/tracks/geojson_serializer_spec.rb
• spec/services/metrics/archives/compression_ratio_spec.rb
• spec/services/metrics/archives/count_mismatch_spec.rb
• spec/services/metrics/archives/operation_spec.rb
• spec/services/metrics/archives/points_archived_spec.rb
• spec/services/metrics/archives/size_spec.rb
• spec/services/metrics/archives/verification_spec.rb
• spec/services/overland/points_creator_spec.rb
• spec/services/own_tracks/point_creator_spec.rb
• spec/services/points/raw_data/archiver_spec.rb
• spec/services/points/raw_data/chunk_compressor_spec.rb
• spec/services/tracks/index_query_spec.rb
• spec/services/tracks/parallel_generator_spec.rb
• spec/services/tracks/segmentation_spec.rb

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ArnyminerZ]

Closing because trying to merge into master. Reopened as #2148