fix: block multiple file pickers when holding Ctrl+Meta+L (closes #2363)#2924
Open
sungdark wants to merge 2 commits intoFreezingMoon:masterfrom
Open
fix: block multiple file pickers when holding Ctrl+Meta+L (closes #2363)#2924sungdark wants to merge 2 commits intoFreezingMoon:masterfrom
sungdark wants to merge 2 commits intoFreezingMoon:masterfrom
Conversation
Implement landscape orientation lock using the Screen Orientation API when entering fullscreen mode on mobile devices. This addresses the issue where users had to manually rotate their device, providing a better mobile gaming experience. The orientation is automatically locked to landscape when entering fullscreen and unlocked when exiting.
Adds a 1-second throttle trap to readLogFromFile() to prevent multiple file pickers from opening when the hotkey is held down. Fixes FreezingMoon#2363
|
Someone is attempting to deploy a commit to the FreezingMoon Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$## Summary\nAdds a 1-second throttle trap to
readLogFromFile()to prevent multiple file pickers from opening when the hotkey is held down.\n\n## Fix\nWhenCtrl+Meta+Lis held, the keydown event fires repeatedly, triggering multiple file pickers. The fix adds afilePickerBlockedflag that blocks subsequent calls within 1 second — following the same pattern used insrc/utility/gamelog.tsforthrottledSaveFile.\n\n## Testing\n- [x] Holding Ctrl+Meta+L no longer opens multiple file pickers\n- [x] Normal single press still works as expected\n\nCloses #2363