fix: lock screen orientation to landscape (#2711)#2917
Open
sungdark wants to merge 1 commit intoFreezingMoon:masterfrom
Open
fix: lock screen orientation to landscape (#2711)#2917sungdark wants to merge 1 commit intoFreezingMoon:masterfrom
sungdark wants to merge 1 commit intoFreezingMoon:masterfrom
Conversation
- Add screen.orientation.lock('landscape') when entering fullscreen
- Unlock orientation when exiting fullscreen
- Attempt orientation lock when game starts (works in fullscreen/PWA context)
- Closes FreezingMoon#2711
|
@penggaolai is attempting to deploy a commit to the FreezingMoon Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Locks the game screen to landscape orientation using the Screen Orientation API.
Changes:
src/ui/fullscreen.ts: AddedlockOrientation()method that callsscreen.orientation.lock('landscape')when entering fullscreen, andscreen.orientation.unlock()when exitingsrc/script.ts: Added orientation lock attempt instartGame()for non-fullscreen PWA contextsHow it works:
"orientation": "landscape"for installed appsCloses #2711