fix: fullscreen button shows user-friendly notification on iOS (closes #2531)#2915
Open
sungdark wants to merge 4 commits intoFreezingMoon:masterfrom
Open
fix: fullscreen button shows user-friendly notification on iOS (closes #2531)#2915sungdark wants to merge 4 commits intoFreezingMoon:masterfrom
sungdark wants to merge 4 commits intoFreezingMoon:masterfrom
Conversation
- Add undo system with saveUndoState() and undoMove() methods - Undo is usable once per round via Delay button or Ctrl+Z - After any move/ability action, Delay button switches to Undo mode - Undo restores creature positions, stats, and removes last action from log - Icon: backward-time from game-icons.net (white foreground, 4px black stroke) - Resets at the start of each new round Fixes FreezingMoon#2704
…#441) When a creature is delayed, the queue avatar now leaps (jumps up then settles) into its new position instead of just sliding. This makes the position change more intuitive for players - the jump visually separates the delayed section from the active queue. - Delayed creatures use a jump animation (translateY -60px then back) - Non-delayed creatures retain the existing smooth slide animation - Animation duration: 500ms for jump, 500ms for slide (consistent)
Issue FreezingMoon#2850: Goey Body upgrade revamp [bounty: 30 XTR] Changes: - Added movementType() method to Goey Body ability that returns 'leap' when upgraded - Modified require() to only trigger trap on death when NOT upgraded - Added 'leap' to Movement type union - Added getLeapHexes() method to Creature class to calculate leap targets - Modified queryMove to include leap hexes when movementType is 'leap' - Leap allows Gumble to jump over units when moving 2+ hexes in straight line The upgraded Goey Body passive now allows Gumble to leap over blocking units during the movement phase instead of creating a trap on death.
- Add isFullscreenSupported() check using vendor-prefixed fullscreenEnabled - Detect iOS and show toast notification when fullscreen is unavailable - Add CSS for toast notification that fades in/out - Fixes FreezingMoon#2531: fullscreen button not working on iOS [bounty: 16 XTR] Receiving address: eB51DWp1uECrLZRLsE2cnyZUzfRWvzUzaJzkatTpQV9
|
Someone is attempting to deploy a commit to the FreezingMoon Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2531 - Fullscreen button not working on iOS [bounty: 16 XTR]
Problem
On iOS Safari/Chrome, the fullscreen button does nothing when tapped because the standard Fullscreen API (
requestFullscreen()) is not supported for arbitrary DOM elements on iOS.Solution
isFullscreenSupported()method that checks for fullscreen API support using vendor-prefixed properties (webkitFullscreenEnabled,mozFullScreenEnabled, etc.)Changes
src/ui/fullscreen.ts: Added iOS detection, fullscreen support check, and toast notificationsrc/style/styles.less: Added CSS for the toast notification with fade-in/out animationTesting
Bounty receiving address: eB51DWp1uECrLZRLsE2cnyZUzfRWvzUzaJzkatTpQV9