fix: hexagon coordinate view tweaks (#2250)#2912
Open
sungdark wants to merge 2 commits intoFreezingMoon:masterfrom
Open
fix: hexagon coordinate view tweaks (#2250)#2912sungdark wants to merge 2 commits intoFreezingMoon:masterfrom
sungdark wants to merge 2 commits intoFreezingMoon:masterfrom
Conversation
- Added movementType function that returns 'flying' when upgraded - Non-upgraded ability still creates death trap (affects all units) - Upgraded ability provides flying movement to leap over units during movement phase - Simplified trap behavior (no longer checks for allies) - Fixes issue: Goey Body upgrade revamp FreezingMoon#2850
|
@sungdark is attempting to deploy a commit to the FreezingMoon Team on Vercel. A member of the Team first needs to authorize it. |
- Remove hex.creature.xray() call in showGrid() so units remain fully visible (no longer tedious x-ray mode) - Add 'dashed' visual state for empty (non-unit) hexes when showGrid is active, displaying a dashed grid overlay - Set empty dashed hexes to 25% opacity when showGrid is active per issue spec - Occupied hexes: creature sprite visible below, coordinates display in overlayHexesGroup (above creatures) - Empty hexes: dashed hex at 25% opacity with coordinates on top in overlayHexesGroup Changes: - src/utility/hexgrid.ts: Modified showGrid() - removed xray call, added dashed class for empty hexes - src/utility/hex.ts: Modified display() - set empty dashed hexes to 25% alpha when showGrid active Bounty: 7 XTR 收款地址：eB51DWp1uECrLZRLsE2cnyZUzfRWvzUzaJzkatTpQV9
sungdark
force-pushed
the
fix/hexagon-coord-view-2250
branch
from
10345b8 to
1a1e207
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Hexagon Coordinate View Tweaks (#2250)
Problem
When viewing hexagon coordinates (by hovering the round marker or holding Shift), the current implementation:
Solution
Modified
showGrid()insrc/utility/hexgrid.tsanddisplay()insrc/utility/hex.ts:hex.creature.xray(val)when viewing coordinates. Creatures remain fully visible.showGridis active, empty (non-unit) hexes now display with thedashedvisual state, showing thehex_dashedtexture instead of solid hexes.dashedclass display at 25% opacity whenshowGridis active, per the issue specification.Changes
src/utility/hexgrid.ts: ModifiedshowGrid()method to:hex.creature.xray(val)call (units no longer go x-ray when viewing coordinates)'dashed'visual state for empty hexes to show dashed grid overlaysrc/utility/hex.ts: Modifieddisplay()method to:this.display.alpha = 0.25) whenshowGridis also activeHow it works
overlayHexesGroup(above creature sprites indisplayHexesGroup), so coordinates are always visible on top of units even without x-rayhex_dashedtexture at 25% opacity whenshowGridis activeBounty: 7 XTR
Recipient Address: eB51DWp1uECrLZRLsE2cnyZUzfRWvzUzaJzkatTpQV9