-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add button to open live chat popup in browser #8278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to open live chat popup in browser #8278
Conversation
src/renderer/components/WatchVideoLiveChat/WatchVideoLiveChat.vue
Outdated
Show resolved
Hide resolved
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Head branch was pushed to by a user without write access
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
…d-live-chat-button-pop-out
Head branch was pushed to by a user without write access
src/renderer/components/WatchVideoLiveChat/WatchVideoLiveChat.css
Outdated
Show resolved
Hide resolved
src/renderer/components/WatchVideoLiveChat/WatchVideoLiveChat.vue
Outdated
Show resolved
Hide resolved
Head branch was pushed to by a user without write access
64c8056 to
0351f99
Compare
Pull Request Type
Related issue
closes #1721
Description
Adds a button that opens a new browser window with the current video live chat
Screenshots
Testing
Go to a video that is listed as "Live"
Click on the "Popout chat" button
See that the current video live chat is opened in a new browser window
Additional context
h4label was replaced withspanbecause of margin was stretching button hover animationthe margin is now applied to the container, replicating the same size as before but the height is ~10px less now