Fix missing sequence numbers on request timeout/termination#200
Merged
Fix missing sequence numbers on request timeout/termination#200
Conversation
If a request is terminated, we remove it from the message state. This causes problems, because we only incremented the sequence numbers _later_. We should really be consuming these early. The current setup was a little weird to begin with, I think this is much cleaner and tidier.
einarmo
force-pushed
the
fix-sequence-number-invalid
branch
from
9c7b0ed to
137867c
Compare
einarmo
commented
Feb 13, 2026
| ) | ||
| .await | ||
| .unwrap(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This test does fail without the fix, so there is a bug here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a request is terminated early, we remove it from the message state. This causes problems, because we only incremented the sequence numbers later. We should really be consuming these early. The current setup was a little weird to begin with, I think this is much cleaner and tidier.
This might fix #125. At the very least it does fix a bug that would look like #125.