Remove unwanted (and unhelpful) extra check#374
Merged
greenc-FNAL merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
- `&& github.event.pull_request.number` was added in #363 to prevent attempts to comment on a non-PR. - However, it failed to take account of when the pull request came from elsewhere (e.g. in the case of an issue comment). - It was anyway unnecessary because the external comment action handles all cases correctly, including when there is no PR to comment upon.
greenc-FNAL
added
bug
knoepfel
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
&& github.event.pull_request.numberwas added in Resolveclang-tidy-fixissues, separate header guard check/fix #363 to preventattempts to comment on a non-PR.
elsewhere (e.g. in the case of an issue comment).
all cases correctly, including when there is no PR to comment upon.