New product query API#267
Conversation
Won't build yet
This handles the API change, and ports the existing creator name check to work with the new product_query.
|
@phlexbot format |
|
No automatic cmake-format fixes were necessary. |
|
Automatic clang-format fixes pushed (commit e8b9e25). |
Also use std::unreachable() instead of kind = "HOW??"s;
beojan
force-pushed
the
new-product-query-api
branch
from
af42dd1 to
dcc0b77
Compare
- Introduce `identifier` - Combine `product_query` and `product_tag` - Express above in terms of `identifier` - Changes to make everything work again
|
@phlexbot format |
|
No automatic cmake-format fixes were necessary. |
|
Automatic clang-format fixes pushed (commit 993ce71). |
Mostly compilation errors, plus exception change in configuration test
|
@phlexbot format |
|
No automatic markdownlint fixes were necessary. |
|
No automatic jsonnetfmt fixes were necessary. |
|
No automatic cmake-format fixes were necessary. |
|
Automatic clang-format fixes pushed (commit 521de38). |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 83.32% 85.25% +1.92%
==========================================
Files 129 122 -7
Lines 3220 2441 -779
Branches 545 389 -156
==========================================
- Hits 2683 2081 -602
+ Misses 324 233 -91
+ Partials 213 127 -86
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
4 participants
Part 1 of the new API requiring creator name to be specified.
After implementing this, I'm not sure creator name should be mandatory after all.
(Sorry, even this has turned into a huge PR, and some of the Jsonnet files got auto-formatted as JSON).