Resolve clang-tidy-fix issues, separate header guard check/fix#363
Merged
greenc-FNAL merged 3 commits intomainfrom Feb 27, 2026
Merged
Resolve clang-tidy-fix issues, separate header guard check/fix#363greenc-FNAL merged 3 commits intomainfrom
clang-tidy-fix issues, separate header guard check/fix#363greenc-FNAL merged 3 commits intomainfrom
Conversation
knoepfel
reviewed
Feb 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #363 +/- ##
==========================================
- Coverage 85.32% 85.20% -0.13%
==========================================
Files 122 122
Lines 2433 2433
Branches 389 389
==========================================
- Hits 2076 2073 -3
- Misses 232 233 +1
- Partials 125 127 +2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
Author
|
@phlexbot python-fix |
Contributor
|
Automatic ruff fixes pushed (commit c71766a). |
greenc-FNAL
changed the title
clang-tidy-* workflow improvementsclang-tidy-* workflow improvements
greenc-FNAL
force-pushed
the
maintenance/clang-tidy-fix-fixes
branch
2 times, most recently
from
1bd3a37 to
9374e8b
Compare
Contributor
Author
|
@phlexbot python-fix |
Contributor
|
Automatic ruff fixes pushed (commit e98ff12). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
Review the full CodeQL report for details. |
greenc-FNAL
force-pushed
the
maintenance/clang-tidy-fix-fixes
branch
2 times, most recently
from
26856de to
095002b
Compare
greenc-FNAL
changed the title
clang-tidy-* workflow improvementsclang-tidy-fix issues, separate header guard check/fix
greenc-FNAL
force-pushed
the
maintenance/clang-tidy-fix-fixes
branch
from
095002b to
5b3fbcc
Compare
Add Python script to check and fix header guards according to the project's naming convention (`X_Y_HEADER_EXT` format). Add GitHub Actions workflows for automated header guard checking and fixing via bot commands. The check workflow runs on PRs with header file changes and reports violations. The fix workflow can be triggered via bot comment to automatically correct guards. Improve clang-tidy workflow to reuse existing fixes from previous runs when possible, avoiding redundant analysis. Add artifact downloading from both check and fix workflows to apply cached fixes. Separate fix generation from application for better control. Update `handle-fix-commit` action to guard PR-specific steps with pull request number checks, preventing failures when running outside PR context. Remove `CreateClangTidyTargets.cmake` module as clang-tidy integration now uses `CMAKE_CXX_CLANG_TIDY` directly. Update `CMakeLists.txt` to report clang-tidy availability without creating custom targets. Disable `llvm-header-guard` check in `.clang-tidy` since the new script enforces project-specific conventions. Upgrade `actions/upload-artifact` from v5 to v6 in `handle-fix-commit` action.
greenc-FNAL
force-pushed
the
maintenance/clang-tidy-fix-fixes
branch
from
b5acb2a to
2b99cb9
Compare
knoepfel
approved these changes
Feb 27, 2026
greenc-FNAL
added a commit
that referenced
this pull request
Feb 27, 2026
- `&& github.event.pull_request.number` was added in #363 to prevent attempts to comment on a non-PR. - However, it failed to take account of when the pull request came from elsewhere (e.g. in the case of an issue comment). - It was anyway unnecessary because the external comment action handles all cases correctly, including when there is no PR to comment upon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Python script to check and fix header guards according
to the project's naming convention (
X_Y_HEADER_EXTformat).Add GitHub Actions workflows for automated header guard
checking and fixing via bot commands. The check workflow
runs on PRs with header file changes and reports violations.
The fix workflow can be triggered via bot comment to
automatically correct guards.
Improve clang-tidy workflow to reuse existing fixes from
previous runs when possible, avoiding redundant analysis.
Add artifact downloading from both check and fix workflows
to apply cached fixes. Separate fix generation from
application for better control.
Update
handle-fix-commitaction to guard PR-specific stepswith pull request number checks, preventing failures when
running outside PR context.
Remove
CreateClangTidyTargets.cmakemodule as clang-tidyintegration now uses
CMAKE_CXX_CLANG_TIDYdirectly. UpdateCMakeLists.txtto report clang-tidy availability withoutcreating custom targets.
Disable
llvm-header-guardcheck in.clang-tidysince thenew script enforces project-specific conventions.
Upgrade
actions/upload-artifactfrom v5 to v6 inhandle-fix-commitaction.