Update the documentation for SQL joins#4144
Open
RobertBrunel wants to merge 1 commit into
Open
Conversation
RobertBrunel
changed the title
alecgrieser
approved these changes
May 8, 2026
Collaborator
alecgrieser
left a comment
alecgrieser
left a comment
There was a problem hiding this comment.
This LGTM. It looks like it will rely on #4122 in order to be factually accurate about outer joins, but once this (or some successor PR with the outer join implementation) goes in, this seems like it would be good to merge
* General cleanup pass over `INNER_JOIN.rst` and `Joins.rst`. * Rename `INNER_JOIN.rst` to `JOIN.rst`. * Add documentation of OUTER JOIN to `JOIN.rst`. Support for outer joins is introduced in PR FoundationDB#4122.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INNER_JOIN.rstandJoins.rst.INNER_JOIN.rsttoJOIN.rst.JOIN.rst. Support for left joins is introduced by PR Support LEFT OUTER JOIN and RIGHT OUTER JOIN #4122.