Add ApplyConfiguration setup for FDB CRDs#2446
Open
johscheuer wants to merge 1 commit intoFoundationDB:mainfrom
Open
Add ApplyConfiguration setup for FDB CRDs#2446johscheuer wants to merge 1 commit intoFoundationDB:mainfrom
johscheuer wants to merge 1 commit intoFoundationDB:mainfrom
Conversation
Contributor
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add ApplyConfiguration setup for FDB CRDs. This allows clients to use the typed
ApplyConfigurationto perform theApply. I converted a few methods in thekubectl-fdbpackage to show how it works. I would convert more/all in another PR since this one is already quite big.Type of change
Discussion
Testing
Ran a manual test with the e2e tests and performed manual testing with the
kubectl-fdbplugin.Documentation
If we think it's worth we can document the
ApplyConfiguration. But those behave similar as the upstreamApplyConfiguration.Follow-up