Skip to content

Add retry limit and allow to read from locked database for management API calls#2444

Merged
johscheuer merged 4 commits intoFoundationDB:mainfrom
johscheuer:add-retry-limit
Mar 24, 2026
Merged

Add retry limit and allow to read from locked database for management API calls#2444
johscheuer merged 4 commits intoFoundationDB:mainfrom
johscheuer:add-retry-limit

Conversation

@johscheuer
Copy link
Copy Markdown
Member

@johscheuer johscheuer commented Mar 23, 2026

Description

Add retry limit and allow to read from locked database. Otherwise some of the methods can be stuck in a retry loop. Adding the ReadLockAware allows the operator to read from a locked database, e.g. in case of a locked database.
Adding the option to allow to read/write from/to a locked database for the management API calls.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

Ran some manual tests. We could add an e2e test where we lock the database and check if the operator is able to perform some operations.

Documentation

Nothing to update.

Follow-up

@johscheuer johscheuer requested a review from nicmorales9 March 23, 2026 15:26
@johscheuer johscheuer added the bug Something isn't working label Mar 23, 2026
Copy link
Copy Markdown
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: a42b038
  • Duration 2:21:11
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Mar 23, 2026
@johscheuer johscheuer reopened this Mar 23, 2026
@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: a42b038
  • Duration 1:52:12
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 9336506
  • Duration 2:22:54
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer requested a review from nicmorales9 March 24, 2026 11:07
@johscheuer johscheuer changed the title Add retry limit and allow to read from locked database Add retry limit and allow to read from locked database for management API calls Mar 24, 2026
Copy link
Copy Markdown
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good but I just want to make sure I understand

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: e914234
  • Duration 1:58:53
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 8aafba8
  • Duration 2:00:24
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Mar 24, 2026
@johscheuer johscheuer reopened this Mar 24, 2026
@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 8aafba8
  • Duration 1:55:45
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer merged commit 36debcb into FoundationDB:main Mar 24, 2026
17 checks passed
@johscheuer johscheuer deleted the add-retry-limit branch March 24, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants