Skip to content

adding support for modify command#2441

Open
09harsh wants to merge 7 commits intoFoundationDB:mainfrom
09harsh:modify_command
Open

adding support for modify command#2441
09harsh wants to merge 7 commits intoFoundationDB:mainfrom
09harsh:modify_command

Conversation

@09harsh
Copy link
Copy Markdown
Contributor

@09harsh 09harsh commented Mar 20, 2026

Description

Please include a summary of the change and which issue is addressed. If this change resolves an issue, please include the issue number in the description.

Added a test to run the modify command on the encrypted backup using backup_modify reconciler.

Fixes: #2393

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

Are there any design details that you would like to discuss further?
No

Testing

Please describe the tests that you ran to verify your changes. Unit tests?
Manual testing?

Do we need to perform additional testing once this is merged, or perform in a larger testing environment?

Ran the test locally.

Documentation

Did you update relevant documentation within this repository?

If this change is adding new functionality, do we need to describe it in our user manual?

If this change is adding or removing subreconcilers, have we updated the core technical design doc to reflect that?

If this change is adding new safety checks or new potential failure modes, have we documented and how to debug potential issues?

N/A

Follow-up

Are there any follow-up issues that we should pursue in the future?

Does this introduce new defaults that we should re-evaluate in the future?
N/A

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 002477b
  • Duration 2:05:25
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Copy Markdown
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of running the modify command manually I would prefer to change the FoundationDBBackup.Spec, so that the operator performs the modify call.

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 30f2c85
  • Duration 2:01:22
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 16a55ad
  • Duration 1:58:35
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 94a30d5
  • Duration 2:13:28
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@09harsh 09harsh marked this pull request as ready for review March 25, 2026 06:38
@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 3ec3a09
  • Duration 1:55:03
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 2355716
  • Duration 1:56:47
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 6dac978
  • Duration 2:07:49
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@09harsh 09harsh requested a review from johscheuer March 25, 2026 11:46
@09harsh 09harsh requested a review from johscheuer March 25, 2026 12:17
@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 4be1cef
  • Duration 2:30:27
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 9e0decb
  • Duration 2:21:14
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Encryption Breaks if modifyBackup sub reconciler runs

3 participants